feat(4173): Send flow with contextual chain selector #13938
+482
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ature can work when its feature flags are enabled make sure to include all env vars: export MM_MULTICHAIN_V1_ENABLED="true" export MM_CHAIN_PERMISSIONS="true" export MM_PER_DAPP_SELECTED_NETWORK="1" export MULTICHAIN_V1="true"
- Replace direct checks of process.env.MM_PER_DAPP_SELECTED_NETWORK in AccountPermissionsConnected.tsx with the isPerDappSelectedNetworkEnabled function. - Update ethereum-chain-utils.js to use isPerDappSelectedNetworkEnabled when switching networks. - Modify selectedNetworkController selectors to use isPerDappSelectedNetworkEnabled for feature flag checks. - Add the isPerDappSelectedNetworkEnabled utility in util/networks/index.js. This change centralizes the per-DApp network logic for better consistency and maintainability.
Add a touchable favicon to the permission summary header that enables network switching for dapps. This combines the dapp's identity (favicon/token) with network selection in a single interactive component. - Replace static WebsiteIcon with touchable BadgeWrapper pattern - Add network badge to indicate current network - Enable network switching via network selector bottom sheet - Add fallback to AvatarToken when favicon unavailable - Guard implementation behind per-dapp network selection feature flag - Preserve original WebsiteIcon when feature disabled This matches the interaction pattern from AccountPermissionsConnected, providing a consistent way to manage dapp-specific networks across the app.
…flag The domain logo container view was incorrectly placed outside the per-dapp network feature flag check. This change moves the container view inside the feature flag condition to ensure consistent UI behavior when the feature is enabled/disabled. - Moved View wrapper inside isPerDappSelectedNetworkEnabled() check - Simplified conditional rendering logic - Maintains existing functionality but with proper feature flag control
…permission sumamry is displayed, keep showing the WebsiteIcon rather than the AvatarFavicon.
…1Enabled rather than its 'corresponding' env variable MULTICHAIN_V1
Remove the permission check for non-permitted network flows in dapps, paving the way for the per-dapp-selected-network feature. Temporary screens handling these flows are pending removal upon feature completion.
- Replace global network selectors with origin-specific useNetworkInfo hook - Update network name and image source to be origin-aware - Update test snapshot for network name changes
- Add origin prop to AccountFromToInfoCard for per-dapp network info - Add debug logs for transaction review flow
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
EtherWizard33
changed the base branch from
main
to
feat-4144-per-dapp-selected-network-poc-2
EtherWizard33
added
No QA Needed
EtherWizard33
added
No E2E Smoke Needed
This commit: - Adds redux state to track chain ID specifically in send flow context - Dispatches chain ID updates when switching networks from send flow - Adds selector and logging to monitor contextual chain ID changes - Only tracks chain ID when network selector is used from send flow
…r reducer - Move contextual chain ID from transaction to networkSelector reducer - Update selectors to read from new location - Add debug logging for state transitions - Reset contextual chain ID when canceling transaction - Initialize contextual chain ID in SendTo component - Display network name in navbar using contextual chain ID BREAKING CHANGE: sendFlowContextualChainId moved from transaction to networkSelector reducer
EtherWizard33
added
Run Smoke E2E
|
note: the no e2e and no qa labels are temporary, will add them once the feature works again |
…d since, on new installs, assets are not shown unless the user switched the GNS to that chain at least one. Other than that, add loging, and set the networkClientId to the contextual to the addTransaction call as suggested by Goktug to make the Confirmation screen of the send flow to be contextual.
… flag the changes specific to the contextual send flow.
…ture flag th e changes specific to the contextual send flow
…agging contextual send flow
…the changes specific to the contextual send flow.
…hind feature flag the changes specific to the contextual send flow.
EtherWizard33
force-pushed
the
feat-4173-send-flow-with-contextual-chain-selector
branch
from
abfa4f4 to
c1fe2ec
Compare
…can probably be removed now or soon.
EtherWizard33
added
Run Smoke E2E
|
EtherWizard33
added
needs-qa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Send flow to use contextual chain selector, WIP.
Related issues
Contributes to: #13674
Manual testing steps
export MM_REMOVE_GLOBAL_NETWORK_SELECTOR="true"yarn watch:cleansendtransaction, where on the first screen of the send flow you pick a network different than the globally selected networkScreenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist