feat(4173): Send flow with contextual chain selector #13938
Draft
+576
−166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ature can work when its feature flags are enabled make sure to include all env vars: export MM_MULTICHAIN_V1_ENABLED="true" export MM_CHAIN_PERMISSIONS="true" export MM_PER_DAPP_SELECTED_NETWORK="1" export MULTICHAIN_V1="true"
- Replace direct checks of process.env.MM_PER_DAPP_SELECTED_NETWORK in AccountPermissionsConnected.tsx with the isPerDappSelectedNetworkEnabled function. - Update ethereum-chain-utils.js to use isPerDappSelectedNetworkEnabled when switching networks. - Modify selectedNetworkController selectors to use isPerDappSelectedNetworkEnabled for feature flag checks. - Add the isPerDappSelectedNetworkEnabled utility in util/networks/index.js. This change centralizes the per-DApp network logic for better consistency and maintainability.
Add a touchable favicon to the permission summary header that enables network switching for dapps. This combines the dapp's identity (favicon/token) with network selection in a single interactive component. - Replace static WebsiteIcon with touchable BadgeWrapper pattern - Add network badge to indicate current network - Enable network switching via network selector bottom sheet - Add fallback to AvatarToken when favicon unavailable - Guard implementation behind per-dapp network selection feature flag - Preserve original WebsiteIcon when feature disabled This matches the interaction pattern from AccountPermissionsConnected, providing a consistent way to manage dapp-specific networks across the app.
…flag The domain logo container view was incorrectly placed outside the per-dapp network feature flag check. This change moves the container view inside the feature flag condition to ensure consistent UI behavior when the feature is enabled/disabled. - Moved View wrapper inside isPerDappSelectedNetworkEnabled() check - Simplified conditional rendering logic - Maintains existing functionality but with proper feature flag control
…permission sumamry is displayed, keep showing the WebsiteIcon rather than the AvatarFavicon.
…1Enabled rather than its 'corresponding' env variable MULTICHAIN_V1
Remove the permission check for non-permitted network flows in dapps, paving the way for the per-dapp-selected-network feature. Temporary screens handling these flows are pending removal upon feature completion.
- Replace global network selectors with origin-specific useNetworkInfo hook - Update network name and image source to be origin-aware - Update test snapshot for network name changes
- Add origin prop to AccountFromToInfoCard for per-dapp network info - Add debug logs for transaction review flow
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
EtherWizard33
changed the base branch from
main
to
feat-4144-per-dapp-selected-network-poc-2
EtherWizard33
added
No QA Needed
EtherWizard33
added
No E2E Smoke Needed
This commit: - Adds redux state to track chain ID specifically in send flow context - Dispatches chain ID updates when switching networks from send flow - Adds selector and logging to monitor contextual chain ID changes - Only tracks chain ID when network selector is used from send flow
…r reducer - Move contextual chain ID from transaction to networkSelector reducer - Update selectors to read from new location - Add debug logging for state transitions - Reset contextual chain ID when canceling transaction - Initialize contextual chain ID in SendTo component - Display network name in navbar using contextual chain ID BREAKING CHANGE: sendFlowContextualChainId moved from transaction to networkSelector reducer
- Move network switch logic inside conditional block in NetworkSelector - Only update active network when not in send flow context - Keep network refresh and update logic outside conditional - Add contextual chain ID logging in Confirm component This prevents the global network from changing when selecting a network during the send flow, maintaining transaction context integrity.
EtherWizard33
commented
Mar 17, 2025
| @@ -1597,7 +1623,7 @@ Confirm.contextType = ThemeContext; | |||
|
|
|||
| const mapStateToProps = (state) => { | |||
| const transaction = getNormalizedTxState(state); | |||
| const chainId = transaction?.chainId; | |||
| const chainId = selectSendFlowContextualChainId(state); | |||
There was a problem hiding this comment.
here the chain id is actually and used to set all state of this component, which is then used when the Confirm button is clicked
…esnt switch global all the time. Note, sending currently only works for linea and mainnet, not for others like arb1
…eader of the SendTo component
…nent to use the contextual chainId when used in the context of the send flow in order to highlight the the current active network (thecontexual one) among the other network in the list of the NetworkSelector component.
EtherWizard33
commented
Apr 15, 2025
| console.log( | ||
| '>>> Confirm component - contextualNetworkClientId', | ||
| contextualNetworkClientId, | ||
| ); | ||
| let result, transactionMeta; | ||
| try { | ||
| ({ result, transactionMeta } = await TransactionController.addTransaction( | ||
| transactionParams, | ||
| { | ||
| deviceConfirmedOn: WalletDevice.MM_MOBILE, |
There was a problem hiding this comment.
networkClientId set from contextual chain id here
…ntId rather than global
… and acountBalance. In more detail, use the contextual chainId to get the networkConfiguration and ultimately the accountBalance, networkName, and networkImage, for the contextual chain rather than the global chain.
…e first token is still showing global network stuff but the tokens below it in the list look like they are specific to the chain
…ed in the token list and the balance displayed in the addressFrom of the SendTo screen. In other words, add the ability for the token list displayed in the contextual send-flow, to display the correct native token and balance. Also in the SendFrom compoment used from the send-to component, ensure it displays the balance of the native token for the contextual chain rather than the wallet chain.
…e token balance to be displayed per contextual chain. In other words, for the displayed balance on the Amount screen, it was using the global chain, it now takes into consideration the contextual chain id which can be used in the send flow.
…ated to take into consideration the contexual chain rather than global chain.
…firmation to validate the amout for the token on the contextual. In orther words, it is now validating the expected token coming from the expected chain, which is the contextual chain rather than the global chain.
…at-4173-send-flow-with-contextual-chain-selector
(all these changed occured over a long period, now this is from a squashed commit, sicne merging was made impossible since the file was moved without proper git mv) - Add sendFlowContextualChainId to manage chain context in send flow - Initialize contextual chain ID with global chain ID on mount - Update component to use contextual chain ID for address display - Modify reset behavior to clear contextual chain ID - Fix relative import paths - Rename selectEvmChainId to selectChainId
…token balances (all these changed occured over a long period, now this is from a squashed commit, sicne merging was made impossible since the file was moved without proper git mv) - Add network-specific selectors for tokens and balances - Update token balance handling to be chain-specific - Add UI improvements for Max button disabled state - Improve network configuration handling with contextual chain ID - Add proper cleanup of contextual chain ID on reset
…ID support
(all these changed occured over a long period, now this is from a squashed commit, since merging was made impossible because the file was moved without proper git mv)
- Replace global network client ID with contextual network client ID for transactions
- Update prop types and state management for transaction metrics
- Add new selectors for tokens, accounts, and network configuration
- Integrate sendFlowContextualChainId for chain-specific operations
- Update transaction validation to use contextual account balances
…duced conflicts and some of them resulted in a bad merge. This commit fixes chunks of code impacted by the bad merge.
EtherWizard33
changed the base branch from
feat-4144-per-dapp-selected-network-poc-2
to
main
EtherWizard33
changed the base branch from
main
to
feat-4144-per-dapp-selected-network-poc
EtherWizard33
changed the base branch from
feat-4144-per-dapp-selected-network-poc
to
feat-4144-per-dapp-updated-from-main-april-7th
…rc-20 token other than the native token. Without this fix, the confirmation screen kept displaying a balance of zero and a caught error, Error in trying to fetch token balance, could be seen in the logs. While adding the networkClientId fixed didnt throw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Send flow to use contextual chain selector, WIP.
Related issues
Contributes to: #13674
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist