Skip to content

chore: Support deeplink for swap #14106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Mar 18, 2025

Description

This PR adds deeplink support for swap with prefill for source token, destination token and value.

The address of source and destination token is handled in caip19 format.
Value is in hexadecimal format.

If any deeplink param is not as expected (is not a caip19 format or it isn't defined) it's redirecting to the swaps screen without pre-filing

If value is not a hexadecimal or not defined is defaulting to 0

You can test this deeplink with this deelink generator website: https://qr-code-generator-tmp.vercel.app/

To figure it out:

Scenarios:

  • When the deeplink have a source and destination token with the same chain id, and that differs from the selected chain id should we switch?
    A: New screen will handle this scenarios because it will have the bridge possibility as well.
  • Is the intention when the chain id of source and destination token differs to navigate to bridge or to consider other scenario, like only navigating to swaps screen without prefills?
    A: New screen will handle this scenarios because it will have the bridge possibility as well.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Mobile Platform team Run Smoke E2E Requires smoke E2E testing labels Mar 18, 2025
@tommasini tommasini requested review from a team as code owners March 18, 2025 20:58
@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue Mar 18, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Mar 18, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 06c8201
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/22504549-eb1a-4520-a6e1-271d80462845

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
73.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@tommasini
Copy link
Contributor Author

Converting this to a draft while waiting for new developments

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
73.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Requires smoke E2E testing team-mobile-platform Mobile Platform team
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

2 participants