-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add profile id metametrics trait #14189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this profile_id generated and set for the first time?
We should have a call to addUserTrait when it's set or updated.
Eventually if you don't have this updated in this PR, it will have to be added in #14088
@NicolasMassart I was under the impression that it would eventually happen at this point Additionally, searching the project for |
It will indeed happen here but only if user comes back to the app or opens it. So ideally the user trait is updated when you actually update the value. The app event listener entrypoint is a workaround that makes sure the value is updated if user crashes the app or never returns for values that are not updated at the moment they are changed. But with #14088 this should not be required, so ideall all new values should update when they are set.
Yes, sorry, I typed it by memory, it's |
Description
This PR adds
profile_id
as a MetaMetrics trait.Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/IDENTITY-58
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist