fix: remove SECURITY_ALERTS_API_ENABLED flag

[vinistevam]

Description

This PR aims to remove the SECURITY_ALERTS_API_ENABLED flag.

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/2041

Manual testing steps

1. Go to test dapp
2. In the section `` test all transactions and signatures and every request should be validated by Security Alert API properly.

Screenshots/Recordings

test_secuirty-alert-api.webm

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 1d036b9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a5189b44-f7c7-44cd-ac37-2839eed6bc40

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8bef7a7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/50af2bed-a271-42de-83f8-b5dcd9a55d9c

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.72%. Comparing base (b539406) to head (8bef7a7).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14221      +/-   ##
==========================================
- Coverage   65.72%   65.72%   -0.01%     
==========================================
  Files        2228     2228              
  Lines       47433    47433              
  Branches     6682     6682              
==========================================
- Hits        31176    31175       -1     
  Misses      14263    14263              
- Partials     1994     1995       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5d45465
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e338ed8b-9fe4-4392-9dda-39ec35825eb8

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[jpuri]

We may also need to delete PPOM bundling code from mobile.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 364bd81
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d4f27cc1-8a35-40af-aac7-dcd83a183437

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud