-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: Prevent malicious dapps from spoofing origin in PermissionsSummary #14422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
|
Closing in lieu of #13394 |
Description
The purpose of this task is to fix a security vulnerability whereby a malicious dapp can trick the user into thinking that a permissions request is coming from a different ("trusted") website rather than their malicious dapp origin
Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/2096
Manual testing steps
https://portfolio.metamask.io
but with the new fix it should still show the codespace URLScreenshots/Recordings
Before
Sorry it's so slow!
android-spoofing-before.mov
After
android-spoofing-after.mov
Pre-merge author checklist
Pre-merge reviewer checklist