Skip to content

feat(snaps): Add Snap export tracking hook to Snap controller init #14428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

david0xd
Copy link
Contributor

@david0xd david0xd commented Apr 4, 2025

Description

This PR adds MetaMetrics tracking hook to Snap controller init. This way we delegate Snap export tracking to Snap controller.

Related issues

Related PR:
MetaMask/snaps#3281
MetaMask/metamask-extension#31553

Notes

Manual testing steps

  1. TBD

Screenshots/Recordings

Before

n/a

After

n/a

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@david0xd david0xd added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed If the PR does not need E2E smoke test run team-snaps-platform Snaps Platform team labels Apr 4, 2025
@david0xd david0xd self-assigned this Apr 4, 2025
Copy link
Contributor

github-actions bot commented Apr 4, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@david0xd david0xd force-pushed the dd/change-snap-export-tracking branch from d2acbaf to 9d493f8 Compare April 24, 2025 10:46
@david0xd david0xd force-pushed the dd/change-snap-export-tracking branch from 9d493f8 to bb70f92 Compare April 28, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants