Skip to content

feat: Update button shape to rounded rectangular #14540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
May 9, 2025
Merged

feat: Update button shape to rounded rectangular #14540

merged 17 commits into from
May 9, 2025
+210 −196

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Apr 8, 2025 •
edited
Loading

Description

This PR updates the border radius of ButtonBase and affected component to 12px for Brand Evolution.
https://www.figma.com/file/ToIjJTBVgkaUEubb7dux9k?node-id=33685:26169&locale=en&type=design#1208645957

Related issues

Fixes: #14451

Manual testing steps

  1. Check everywhere please

Screenshots/Recordings

Before

After

Simulator.Screen.Recording.-.iPhone.13.Pro.-.2025-04-08.at.16.31.22.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen requested review from a team as code owners April 8, 2025 22:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen marked this pull request as draft April 8, 2025 22:40
@metamaskbot metamaskbot added the team-design-system All issues relating to design system in Mobile label Apr 8, 2025
@brianacnguyen brianacnguyen marked this pull request as ready for review April 8, 2025 23:34
@brianacnguyen brianacnguyen requested a review from a team as a code owner April 8, 2025 23:34
@brianacnguyen brianacnguyen self-assigned this Apr 8, 2025
@brianacnguyen brianacnguyen added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: eb98676
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/05892457-9660-4f15-8e0f-2d6ff275b192

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@brianacnguyen brianacnguyen added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 507ec22
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ccbdba55-3f1c-45df-879d-bbfc4668bcc5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Prithpal-Sooriya
Prithpal-Sooriya previously approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from assets perspective. It adds some boarder radius to our buttons.

infiniteflower
infiniteflower previously approved these changes Apr 9, 2025
View reviewed changes
@brianacnguyen brianacnguyen added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label May 6, 2025
@brianacnguyen brianacnguyen added No QA Needed Apply this label when your PR does not need any QA effort. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels May 8, 2025
@brianacnguyen brianacnguyen added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ea034ef
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f151db63-99db-459f-a80b-b976f14b6e41

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@brianacnguyen brianacnguyen enabled auto-merge May 9, 2025 00:09
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@brianacnguyen brianacnguyen added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 87f6046
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1973106d-fa58-43fc-8fdb-e17d288b228e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@brianacnguyen brianacnguyen added this pull request to the merge queue May 9, 2025
Merged via the queue into main with commit 140d2dd May 9, 2025
49 of 51 checks passed
@brianacnguyen brianacnguyen deleted the update/button-shape branch May 9, 2025 20:26
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nickewansmith nickewansmith nickewansmith approved these changes

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@smilingkylan smilingkylan smilingkylan left review comments

@OGPoyraz OGPoyraz OGPoyraz left review comments

@infiniteflower infiniteflower infiniteflower left review comments

Assignees

@brianacnguyen brianacnguyen

Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.48.0 Issue or pull request that will be included in release 7.48.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-design-system All issues relating to design system in Mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MOB] Update Button shape from rounded to rectangular
8 participants
@brianacnguyen @nickewansmith @smilingkylan @OGPoyraz @georgewrmarshall @Prithpal-Sooriya @infiniteflower @metamaskbot