Skip to content

fix: Add e2e label check #14542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Add e2e label check #14542

wants to merge 1 commit into from

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Apr 8, 2025

Description

Update check-pr-has-required-labels action to check for the existence of either the Run Smoke E2E or No E2E Smoke Needed label.

Related issues

Fixes: Failure https://github.com/MetaMask/metamask-mobile/actions/runs/14345178356/job/40213426099?pr=14537

Manual testing steps

  • Apply the No E2E Smoke Needed label, the PR should be unblocked for the label check action. Should be able to merge via the merge queue

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team as a code owner April 8, 2025 23:07
@Cal-L Cal-L added the team-mobile-platform Mobile Platform team label Apr 8, 2025
Copy link
Contributor

github-actions bot commented Apr 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 8, 2025
@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue Apr 8, 2025
@Cal-L Cal-L enabled auto-merge April 8, 2025 23:09
@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Apr 8, 2025
Copy link

sonarqubecloud bot commented Apr 8, 2025

@Cal-L Cal-L added this pull request to the merge queue Apr 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 8, 2025
@Cal-L Cal-L added this pull request to the merge queue Apr 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform Mobile Platform team
Projects
Status: Review finalised - Ready to be merged
Development

Successfully merging this pull request may close these issues.

2 participants