feat: improve sdk disconnection flow #14649
Draft
+115
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed unused imports and consolidated necessary ones for better readability. - Refactored the `hideSheet` and `handleConfirm` functions to use `useCallback` for performance optimization. - Simplified the rendering logic in `renderConnectScreens` by removing unnecessary conditions. - Enhanced overall code structure for improved maintainability.
- Added `markedForDeletion`, `failedTerminationAttempts`, and `lastTerminationAttempt` properties to the `Connection` interface to manage connection states more effectively. - Updated `SDKSessionsManager` to filter out connections marked for deletion. - Enhanced `removeChannel` logic to handle termination attempts and retry logic based on failure counts. - Implemented checks in `asyncInit` to retry termination for connections marked for deletion.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Depends on #14605
Manual testing steps
Screenshots/Recordings
Before
failed_deletion.mov
After
Pre-merge author checklist
Pre-merge reviewer checklist