-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
refactor: snaps UI tests #14705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: snaps UI tests #14705
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
|
Description
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:
SnapUIInput
), tests usingrenderInterface
inSnapUIRenderer.test.tsx
and then individual tests within thecomponents
subfolder that test the respective template mapper.renderInterface
re-usable and follow the testing pattern being used in the extension with tests usingrenderInterface
e.g.input.test.ts
. UsingrenderInterface
we essentially test the component from mapping to rendering. This PR moves existing tests in "SnapUI" prefixed folders that do not have a corresponding test in thecomponents
subfolder. It also moves out some tests fromSnapUIRenderer.test.tsx
into their own files, similar to how we did in the extension.Note: A subsequent PR will be opened to convert existing tests within the
components
subfolder to therenderInterface
format and migrate any remaining "SnapUI" prefixed tests.Related issues
Fixes: #14531
Pre-merge author checklist
Pre-merge reviewer checklist