feat: Multichain NFT import #14748

gambinish · 2025-04-19T00:15:12Z

Description

Adds NetworkSelector to NFT import flow
Adds networkClientId and userAddress signature to NftController.removeAndIgnoreNft calls
Adds networkClientId signature to NftController.addNft calls

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Screen.Recording.2025-04-18.at.5.21.36.PM.mov

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…nature to removeAndIgnoreNft and addNft

github-actions · 2025-04-19T00:15:24Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…mask-mobile into feat/multichain-nft-import

github-actions · 2025-04-19T00:43:48Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 14a546d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0a9e88df-1e78-44a2-99cc-170c29682823

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-04-21T21:17:31Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7ab19b1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2f52b3f3-5fc4-4c0a-8325-822f29252787

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-04-21T22:57:04Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 678666d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e47ccbe9-cc5a-434b-8049-74132b7e5f80

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-04-22T03:57:40Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1f58f3e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f92dc0a0-efcd-4a76-987e-a397d76fa1e3

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2025-04-22T22:51:03Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2e74bf6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/922302e3-1e80-47fb-aec7-f30adfbab224

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

codecov-commenter · 2025-04-22T23:04:30Z

Codecov Report

Attention: Patch coverage is 47.45763% with 31 lines in your changes missing coverage. Please review.

Project coverage is 67.55%. Comparing base (ca4eb16) to head (aa042d5).

Files with missing lines	Patch %	Lines
app/components/UI/AddCustomCollectible/index.tsx	8.33%	10 Missing and 1 partial ⚠️
app/components/UI/Collectibles/index.js	0.00%	8 Missing ⚠️
app/components/UI/AddCustomCollectible/util.ts	82.35%	3 Missing ⚠️
...ents/UI/AddCustomToken/NetworkSelectorDropdown.tsx	72.72%	2 Missing and 1 partial ⚠️
.../components/UI/CollectibleContractElement/index.js	25.00%	3 Missing ⚠️
app/components/Views/NftOptions/NftOptions.tsx	66.66%	1 Missing and 1 partial ⚠️
app/components/Views/AddAsset/AddAsset.tsx	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14748      +/-   ##
==========================================
+ Coverage   67.50%   67.55%   +0.04%     
==========================================
  Files        2307     2309       +2     
  Lines       49618    49648      +30     
  Branches     7198     7205       +7     
==========================================
+ Hits        33496    33541      +45     
+ Misses      14005    13986      -19     
- Partials     2117     2121       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…mask-mobile into feat/multichain-nft-import

github-actions · 2025-04-23T00:06:56Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 673957d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/872bc3f6-dde8-41c3-a7b3-6b7738a68095

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

sonarqubecloud · 2025-04-23T01:45:08Z

Quality Gate failed

Failed conditions
64.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

github-actions · 2025-04-23T01:50:55Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1034417
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4ef585f2-952a-47c2-bcd6-8ddd590b563b

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

app/components/UI/AddCustomCollectible/index.tsx

sahar-fehri · 2025-04-23T11:23:55Z

app/components/UI/AddCustomCollectible/index.tsx

@@ -197,6 +168,7 @@ const AddCustomCollectible = ({
    // TODO: Replace "any" with type
    // eslint-disable-next-line @typescript-eslint/no-explicit-any
    const { NftController } = Engine.context as any;


Adding comment here because i couldn't add a comment on the correct line ^^"
But there is a logic before adding NFT that validates collectible address validateCustomCollectible and ownership
validateCollectibleOwnership; I think those should be updated as well to pass the networkClientId of the network the user has selected.

sahar-fehri · 2025-04-23T11:30:55Z

app/components/Views/AddAsset/AddAsset.tsx

@@ -282,6 +282,13 @@ const AddAsset = () => {
        <AddCustomCollectible
          navigation={navigation}
          collectibleContract={collectibleContract}
+          selectedNetwork={
+            selectedNetwork
+              ? networkConfigurations?.[selectedNetwork as Hex]?.name


Can we pass the networkConfiguration object instead of just the name? and leave it to the component to display the name?
I think the AddCustomCollectible would also need the networkclientId from the networkConfiguration to pass it down to the controller fcts

app/components/UI/AddCustomCollectible/index.tsx

gambinish added 2 commits April 18, 2025 16:03

fix: Add Network picker to nft import flow

c0da631

fix: Add Network Selector to Import NFT form, add networkClientId sig…

b7f194e

…nature to removeAndIgnoreNft and addNft

metamaskbot added the team-assets label Apr 19, 2025

gambinish and others added 4 commits April 18, 2025 17:24

Merge branch 'main' into feat/multichain-nft-import

0eefa7e

fix: Lint

2e23fdc

Merge branch 'feat/multichain-nft-import' of github.com:MetaMask/meta…

fc9f5d4

…mask-mobile into feat/multichain-nft-import

fix: Lint tsc

14a546d

gambinish added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 19, 2025

gambinish added 2 commits April 21, 2025 13:57

chore: Update snapshots

dbdf1d1

chore: Merge main, address conflicts

7ab19b1

gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 21, 2025

fix: e2e

678666d

gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 21, 2025

gambinish added 3 commits April 21, 2025 17:35

fix: Incorrect testId

c7bb118

fix: e2e nft detail network selection

4b76a45

chore: Update snapshots

1f58f3e

gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 22, 2025

fix: Existing unit tests

ad40a0f

metamaskbot added the bitrise-result-ready label Apr 22, 2025

github-actions bot removed the bitrise-result-ready label Apr 22, 2025

gambinish added 2 commits April 21, 2025 21:38

fix: lint

885e5b1

chore: disable import button when no network is selected

f0cbc5a

Merge branch 'main' into feat/multichain-nft-import

aa042d5

gambinish removed the DO-NOT-MERGE Pull requests that should not be merged label Apr 22, 2025

metamaskbot added the bitrise-result-ready label Apr 22, 2025

github-actions bot removed the bitrise-result-ready label Apr 22, 2025

gambinish and others added 4 commits April 22, 2025 16:34

Break out removeNft function, write utility, and unit test

5a0f70c

Merge branch 'feat/multichain-nft-import' of github.com:MetaMask/meta…

ca3833e

…mask-mobile into feat/multichain-nft-import

Merge branch 'main' into feat/multichain-nft-import

16049db

fix: Lint tsc

673957d

gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 23, 2025

gambinish added 3 commits April 22, 2025 17:58

chore: Bump unit test coverage

72bc3c9

fix: Lint

cf3933f

fix: Bump test coverage

1034417

gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 23, 2025

metamaskbot added the bitrise-result-ready label Apr 23, 2025

github-actions bot removed the bitrise-result-ready label Apr 23, 2025

sahar-fehri reviewed Apr 23, 2025

View reviewed changes

app/components/UI/AddCustomCollectible/index.tsx Outdated Show resolved Hide resolved

sahar-fehri reviewed Apr 23, 2025

View reviewed changes

app/components/UI/AddCustomCollectible/index.tsx Show resolved Hide resolved

hesterbruikman added the Remove GNS label May 1, 2025

gambinish and others added 3 commits May 6, 2025 16:06

chore: Merge main, address conflicts

a07a754

chore: Pass networkClientId instead of chainId

7373b39

Merge branch 'main' into feat/multichain-nft-import

df8f18d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Multichain NFT import #14748

feat: Multichain NFT import #14748

gambinish commented Apr 19, 2025 •

edited

Loading

github-actions bot commented Apr 19, 2025

github-actions bot commented Apr 19, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Apr 21, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Apr 21, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Apr 22, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Apr 22, 2025 •

edited by metamaskbot

Loading

codecov-commenter commented Apr 22, 2025

github-actions bot commented Apr 23, 2025 •

edited by metamaskbot

Loading

sonarqubecloud bot commented Apr 23, 2025

github-actions bot commented Apr 23, 2025 •

edited by metamaskbot

Loading

sahar-fehri Apr 23, 2025

sahar-fehri Apr 23, 2025

gambinish May 7, 2025

feat: Multichain NFT import #14748

Are you sure you want to change the base?

feat: Multichain NFT import #14748

Conversation

gambinish commented Apr 19, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Apr 19, 2025

github-actions bot commented Apr 19, 2025 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Apr 21, 2025 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Apr 21, 2025 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Apr 22, 2025 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Apr 22, 2025 • edited by metamaskbot Loading

Bitrise

codecov-commenter commented Apr 22, 2025

Codecov Report

github-actions bot commented Apr 23, 2025 • edited by metamaskbot Loading

Bitrise

sonarqubecloud bot commented Apr 23, 2025

Quality Gate failed

github-actions bot commented Apr 23, 2025 • edited by metamaskbot Loading

Bitrise

sahar-fehri Apr 23, 2025

Choose a reason for hiding this comment

sahar-fehri Apr 23, 2025

Choose a reason for hiding this comment

gambinish May 7, 2025

Choose a reason for hiding this comment

gambinish commented Apr 19, 2025 •

edited

Loading

github-actions bot commented Apr 19, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Apr 21, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Apr 21, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Apr 22, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Apr 22, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Apr 23, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Apr 23, 2025 •

edited by metamaskbot

Loading