feat: create solana account and call discoverAccounts during creation and import of hd keyring cp-7.47.0

[montelaidev]

Description

This PR enables the discover Accounts call during import srp and creation of a new vault.

Changes:

1. update multiSrp/index to call addDiscoveredAccounts and add tests.
2. Updates SolanaNewFeatureContent.test.tsx to use the MultichainWalletSnapFactory
3. Refactor name logic into a separate file getMultichainAccountName in AddNewAccount
4. In Authentication addDiscoveredAccounts is called after createNewVaultandRestore and createNewVaultAndKeychain

Related issues

Fixes:

Manual testing steps

Using the beta build.

Onboarding flow

1. With a new MM instance, create a new vault.
2. See that there is a new solana account along with the ethereum account.

Import new srp during onboarding

1. With a new MM instance, import a new srp
2. See that there is a new solana account along with the ethereum account.

With an existing MM vault.

1. Click on account selector.
2. Click on Secrete Recovery Phrase
3. Add a new srp.
4. See that there is a new solana account created after the import.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 88.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.85%. Comparing base (cf99fce) to head (0f88b78).

Files with missing lines	Patch %	Lines
app/core/SnapKeyring/MultichainWalletSnapClient.ts	77.77%	3 Missing and 1 partial ⚠️
...core/SnapKeyring/utils/getMultichainAccountName.ts	90.90%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14775      +/-   ##
==========================================
+ Coverage   67.81%   67.85%   +0.03%     
==========================================
  Files        2339     2340       +1     
  Lines       50384    50405      +21     
  Branches     7427     7431       +4     
==========================================
+ Hits        34168    34202      +34     
+ Misses      14052    14036      -16     
- Partials     2164     2167       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3d1dc7b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4e6bca89-94f5-4ac8-9da6-a044bc7b5cf5

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud