Skip to content

feat: Add token search events #14778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 211 commits into
base: main
Choose a base branch
from
Open

feat: Add token search events #14778

wants to merge 211 commits into from

Conversation

ziad-saab
Copy link
Contributor

Description

Add token search events

Related issues

Fixes: MMPD-1591

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Bigshmow and others added 30 commits January 21, 2025 19:42
…etaMask/metamask-mobile into add-tokens-search-discovery-controller
@ziad-saab ziad-saab requested review from a team as code owners April 22, 2025 19:29
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 22, 2025
Copy link
Contributor

github-actions bot commented Apr 22, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 186f589
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c6a79e09-2825-4bab-ab47-6bcab7c7b18f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@ziad-saab ziad-saab changed the title Add token search events feat: Add token search events Apr 22, 2025
@ziad-saab ziad-saab added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed If the PR does not need E2E smoke test run and removed INVALID-PR-TEMPLATE PR's body doesn't match template Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 28, 2025
@ziad-saab
Copy link
Contributor Author

@sethkfman any thoughts on how to get this through without developing a whole test suite for BrowserTab?

@ziad-saab ziad-saab enabled auto-merge April 30, 2025 15:13
@sethkfman sethkfman added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label May 2, 2025
@ziad-saab ziad-saab added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No E2E Smoke Needed If the PR does not need E2E smoke test run labels May 2, 2025
Copy link
Contributor

github-actions bot commented May 2, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3984434
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a3910e1f-cfdb-43fc-9faa-21cab739339d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarqubecloud bot commented May 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
37.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-portfolio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants