Skip to content

[DO NOT MERGE] fix: Temp mock-server refactor #14808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE] fix: Temp mock-server refactor #14808

wants to merge 1 commit into from
+120 −42

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Apr 23, 2025 •
edited
Loading

Description

Temporary PR to test refactored mock-server

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz changed the title Temp fix: Temp mock-server refactor Apr 23, 2025
@OGPoyraz OGPoyraz added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 23, 2025
@metamaskbot metamaskbot added team-confirmations Push issues to confirmations team INVALID-PR-TEMPLATE PR's body doesn't match template labels Apr 23, 2025
@OGPoyraz OGPoyraz force-pushed the refactor/mock-server branch from 2531edc to a59fd6e Compare April 23, 2025 20:26
@MetaMask MetaMask deleted a comment from github-actions bot Apr 23, 2025
@OGPoyraz OGPoyraz added no-changelog Indicates no external facing user changes, therefore no changelog documentation needed and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Apr 23, 2025
@OGPoyraz OGPoyraz force-pushed the refactor/mock-server branch from 9420d61 to b8d1e17 Compare April 23, 2025 21:34
@OGPoyraz OGPoyraz requested a review from a team as a code owner April 23, 2025 21:34
@OGPoyraz
Copy link
Member Author

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a3e9ba4f-93b4-4f21-a963-9eb25b079084

digiwand
digiwand approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@digiwand digiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice updates 👍🏼

vinistevam
vinistevam reviewed Apr 24, 2025
View reviewed changes
e2e/api-mocking/mock-server.js
console.log('Received:', JSON.stringify(requestBodyJson, null, 2));
console.log(
'Differences:',
JSON.stringify(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@OGPoyraz OGPoyraz force-pushed the refactor/mock-server branch from 46a4926 to b96ef95 Compare April 24, 2025 06:58
@OGPoyraz
Copy link
Member Author

Latest Bitrise build: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e4c2b617-761a-4730-ab49-758c60ee6254

@OGPoyraz OGPoyraz changed the title fix: Temp mock-server refactor [DO NOT MERGE] fix: Temp mock-server refactor Apr 24, 2025
@OGPoyraz OGPoyraz marked this pull request as draft April 24, 2025 09:43
@OGPoyraz OGPoyraz added the DO-NOT-MERGE Pull requests that should not be merged label Apr 24, 2025
@OGPoyraz OGPoyraz closed this May 4, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@digiwand digiwand digiwand approved these changes

@vinistevam vinistevam vinistevam approved these changes

Assignees
No one assigned
Labels
DO-NOT-MERGE Pull requests that should not be merged no-changelog Indicates no external facing user changes, therefore no changelog documentation needed Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OGPoyraz @digiwand @vinistevam @metamaskbot