Skip to content

feat: added network selector to the request payment flow #14954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Apr 28, 2025

Description

This PR enhances the Request Payment feature by implementing network-specific payment requests and improving the asset selection experience. When users generate payment requests through the 'Receive' flow (accessible via the Scan icon or Action menu), they can now specify their desired network and select relevant assets for that network.

Key Changes

  1. Added network selection dropdown in the Request Payment flow
  2. Updated header UI for request payment flow

Testing Notes

  • Verified network switching works correctly when opening payment request links
  • Confirmed asset list updates appropriately when changing networks
  • Tested deep link generation and handling across different networks

Related issues

Fixes: 4776

Manual testing steps

  1. Run REMOVE_GNS=true yarn watch:clean
  2. Goto the "Request Payment" flow which is accessible from the action menu > receive OR from the QR code menu
  3. Switch networks and observe that the asset list changes
  4. When accepting a payment request observe that the network changes t

Screenshots/Recordings

Request Payment

request_payment.mov

Receive Payment

recieve_payment.MP4

Before

iOS Android
ios_before android_before

After

iOS Android
ios_after android_after

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward marked this pull request as ready for review April 29, 2025 18:09
@vinnyhoward vinnyhoward added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 29, 2025
Copy link
Contributor

github-actions bot commented Apr 29, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c6d4c39
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/25176dff-05c7-400b-8dd2-38a7121a479e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 29, 2025
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: fbe953f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/363f611c-c0a7-43b8-9f35-57172ac15306

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 29, 2025
Copy link
Contributor

github-actions bot commented Apr 29, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e1435b8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a32a85d2-a697-4905-bcff-1a994db6146b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added the No QA Needed Apply this label when your PR does not need any QA effort. label Apr 30, 2025
@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 30, 2025
Copy link
Contributor

github-actions bot commented Apr 30, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ac2415f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b82b2431-5a92-46d3-bf7d-435d277451f4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 30, 2025
Copy link
Contributor

github-actions bot commented Apr 30, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 1019087
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/800b2e63-030f-47ff-9095-4c3bf587a66b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 1, 2025
Copy link
Contributor

github-actions bot commented May 1, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: efc38a9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/67a4f9ad-ae76-479c-8214-9dd323431d04

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 2, 2025
Copy link
Contributor

github-actions bot commented May 2, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: af5df60
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c6e86a82-c11f-4674-95c2-97c4ca135608

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No QA Needed Apply this label when your PR does not need any QA effort. Remove GNS Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants