-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add asset selector #14958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add asset selector #14958
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
app/components/Snaps/SnapUIAssetSelector/SnapUIAssetSelector.tsx
Outdated
Show resolved
Hide resolved
app/components/Snaps/SnapUIAssetSelector/SnapUIAssetSelector.tsx
Outdated
Show resolved
Hide resolved
app/components/Snaps/SnapUIAssetSelector/SnapUIAssetSelector.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - please wait for @GuillaumeRx to sign off too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See latest comment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
Description
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:
AssetSelector
from extension.Related issues
Fixes: MetaMask/snaps#3285
Manual testing steps
Screenshots/Recordings
After
Recording:
Screen.Recording.2025-05-05.at.5.45.11.PM.mov
Disabled State
Error State
Pre-merge author checklist
Pre-merge reviewer checklist