Skip to content

feat(ramp): add fiat balance to non evm #14983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

wachunei
Copy link
Member

Description

This PRs adds the fiat equivalent for the current selected non-evm token.

Related issues

Fixes:

Manual testing steps

  1. Go Buy flow
  2. Solana balance must translate to a fiat equivalent

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-ramp issues related to Ramp features label Apr 29, 2025
@wachunei wachunei added the Run Smoke E2E Requires smoke E2E testing label Apr 29, 2025
Copy link
Contributor

github-actions bot commented Apr 29, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b843b3f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6af400c4-f4e7-4b08-a67b-37c833d9e015

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Apr 29, 2025
Copy link
Contributor

github-actions bot commented Apr 29, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6c2f44b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b1004551-19ef-4982-9c6f-8f5f4967ff81

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.86%. Comparing base (f518fc9) to head (6c2f44b).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
app/components/UI/Ramp/hooks/useBalance.ts 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14983      +/-   ##
==========================================
+ Coverage   67.84%   67.86%   +0.02%     
==========================================
  Files        2343     2345       +2     
  Lines       50476    50498      +22     
  Branches     7452     7454       +2     
==========================================
+ Hits        34246    34272      +26     
+ Misses      14062    14056       -6     
- Partials     2168     2170       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wachunei wachunei added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 30, 2025
@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue Apr 30, 2025
@wachunei wachunei marked this pull request as ready for review April 30, 2025 12:33
@wachunei wachunei requested a review from a team as a code owner April 30, 2025 12:33
@wachunei wachunei added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-ramp-qa Tickets that need feature QA on the ramps flows Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 5, 2025
Copy link
Contributor

github-actions bot commented May 5, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8351d8b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/86b3a142-aa65-45aa-b2e8-1102e1150664

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

sonarqubecloud bot commented May 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-ramp-qa Tickets that need feature QA on the ramps flows Run Smoke E2E Requires smoke E2E testing team-ramp issues related to Ramp features
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

3 participants