Skip to content

feat: Add advanced details row into transfer confirmations #15004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

OGPoyraz
Copy link
Member

Description

This PR mainly adds AdvancedDetailsRow into transfer confirmations.

Also adjusts couple things

  • Rename ExpandableSection into Expandable
  • In order to give freedom parent components to set what component could trigger expanded modal this doesn't apply InfoSection now. We do this to prevent styling issues of putting icons and such.
  • Adds new prop to InfoRow withIcon that puts an icon on the right
  • All signature related changes are due to Expandable changes - please see that there is no functional or design change in the screenshots.
  • All changes contributes Expandable to be consistent with single InfoRow components like network fees - please see "before" section in screenshots

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4789

Manual testing steps

Screenshots/Recordings

Before

Inconistent style with network and advanced

After

transfer confirmation

transfer confirmation expanded

signature example

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner April 30, 2025 11:14
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Apr 30, 2025
@OGPoyraz OGPoyraz added No QA Needed Apply this label when your PR does not need any QA effort. no-changelog Indicates no external facing user changes, therefore no changelog documentation needed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 30, 2025
Copy link
Contributor

github-actions bot commented Apr 30, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2041a9f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a39c995d-e0b9-4793-9bc4-8deabe10348f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.84%. Comparing base (cf99fce) to head (894c984).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15004      +/-   ##
==========================================
+ Coverage   67.81%   67.84%   +0.02%     
==========================================
  Files        2339     2345       +6     
  Lines       50384    50433      +49     
  Branches     7427     7433       +6     
==========================================
+ Hits        34168    34215      +47     
- Misses      14052    14054       +2     
  Partials     2164     2164              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 2, 2025
Copy link
Contributor

github-actions bot commented May 2, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5f10d03
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5c7863bb-39f4-43a0-be0f-c2a42e31e9ed

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 2, 2025
Copy link
Contributor

github-actions bot commented May 2, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 16929d2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b1bf42ba-3b49-4358-b67a-b1839f057a99

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No QA Needed Apply this label when your PR does not need any QA effort. no-changelog Indicates no external facing user changes, therefore no changelog documentation needed Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants