-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: Add advanced details row into transfer
confirmations
#15004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15004 +/- ##
==========================================
+ Coverage 67.81% 67.84% +0.02%
==========================================
Files 2339 2345 +6
Lines 50384 50433 +49
Branches 7427 7433 +6
==========================================
+ Hits 34168 34215 +47
- Misses 14052 14054 +2
Partials 2164 2164 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
|
Description
This PR mainly adds
AdvancedDetailsRow
into transfer confirmations.Also adjusts couple things
ExpandableSection
intoExpandable
InfoSection
now. We do this to prevent styling issues of putting icons and such.InfoRow
withIcon
that puts an icon on the rightExpandable
changes - please see that there is no functional or design change in the screenshots.Expandable
to be consistent with singleInfoRow
components like network fees - please see "before" section in screenshotsRelated issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4789
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist