Skip to content

feat: Add function getCallsStatus for middleware to handle wallet_getCallsStatus requests #15015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

feat: Add function getCallsStatus for middleware to handle wallet_getCallsStatus requests #15015

wants to merge 30 commits into from
+576 −308

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Apr 30, 2025

Description

Add function getCallsStatus for middleware to handle wallet_getCallsStatus requests

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4787

Manual testing steps

  1. Go to test dapp
  2. Submit batch request
  3. Check request status

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

jpuri added 17 commits April 23, 2025 18:11
@jpuri jpuri added the team-confirmations Push issues to confirmations team label Apr 30, 2025
@jpuri jpuri requested a review from a team as a code owner April 30, 2025 12:35
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri force-pushed the support_call_status branch from 3f7e1d3 to 333aec7 Compare April 30, 2025 12:36
@jpuri
Copy link
Contributor Author

jpuri commented Apr 30, 2025 •
edited
Loading

The PR also moves code to file eip5792.ts

@jpuri jpuri mentioned this pull request May 1, 2025
Merged
7 tasks
Base automatically changed from send_call_validations to main May 5, 2025 15:47
@github-actions github-actions bot requested a review from a team as a code owner May 5, 2025 15:48
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 6, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
96.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label May 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 918ca3b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/59c46259-9b8f-46ec-a40e-fbdedcad52ac

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

matthewwalsh0
matthewwalsh0 approved these changes May 7, 2025
View reviewed changes
app/core/RPCMethods/eip5792.ts

export type EIP5792Messenger = Messenger<Actions, never>;

export async function getCallsStatus(id: Hex): Promise<GetCallsStatusResult> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, ideally we keep all exported functions and types at the top?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpuri @matthewwalsh0 @metamaskbot