Skip to content

perf: persist Snap accounts only once #15027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Apr 30, 2025

Description

The AccountsController is already listening to the KeyringController:stateChange event and will automatically adds newly created account from every keyrings. This would avoid triggering an unnecessary AccountsController:stateChange.

Related issues

N/A

Manual testing steps

  1. Make a beta build
  2. Creates a Solana account
  3. It should be created just as before

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ccharly ccharly added team-accounts area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. labels Apr 30, 2025
@ccharly ccharly self-assigned this Apr 30, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ccharly ccharly added the No QA Needed Apply this label when your PR does not need any QA effort. label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. No QA Needed Apply this label when your PR does not need any QA effort. team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant