Skip to content

fix: flask build application id mismatch #15070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −2
Open

fix: flask build application id mismatch #15070

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions scripts/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,26 @@ buildAndroidRunQA(){

buildAndroidRunFlask(){
prebuild_android
#react-native run-android --port=$WATCHER_PORT --variant=flaskDebug --active-arch-only
npx expo run:android --no-install --port $WATCHER_PORT --variant 'flaskDebug'
# Add debug info
echo "METAMASK_BUILD_TYPE: ${METAMASK_BUILD_TYPE}"
echo "Running with Flask variant, which should use app ID: io.metamask.flask"

# Build the debug app explicitly first to ensure we have the proper app ID
cd android && ./gradlew assembleFlaskDebug --no-daemon && cd ..

# Install the explicitly built APK with the correct package name
adb install -r android/app/build/outputs/apk/flask/debug/app-flask-debug.apk

# Launch the app
echo "Launching app: io.metamask.flask"
adb shell am start -n io.metamask.flask/io.metamask.MainActivity

# Provide instructions for starting the development server
echo ""
echo "🚀 App installed and launched successfully!"
echo "📱 Now start the Metro development server in a separate terminal with:"
echo " yarn watch"
echo ""
}

buildIosDevBuild(){
Expand Down
Loading