Skip to content

feat: upgrade @metamask/providers to v22.1.0 #15073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Conversation

abretonc7s
Copy link
Contributor

@abretonc7s abretonc7s commented May 2, 2025

Description

This pull request upgrades @metamask/providers from v18.3.1 to v22.1.0, aligning with the MetaMask extension's latest provider package. The update adopts ES modules, modern streaming patterns with readable-stream v3.6.2, and replaces the deprecated pump with the standard pipeline function.

Improvement/Solution:

  • Upgraded @metamask/providers to v22.1.0 and readable-stream to v3.6.2.
  • Switched to ES module imports for @metamask/object-multiplex and other dependencies.
  • Replaced pump with pipeline for stream handling in scripts/inpage-bridge/src/provider.js.
  • Updated Webopramask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented May 2, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-sdk SDK team label May 2, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.77%. Comparing base (25ed17c) to head (c5e222b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15073   +/-   ##
=======================================
  Coverage   67.77%   67.77%           
=======================================
  Files        2344     2344           
  Lines       50621    50620    -1     
  Branches     7484     7484           
=======================================
+ Hits        34306    34307    +1     
+ Misses      14135    14133    -2     
  Partials     2180     2180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 2, 2025
@abretonc7s abretonc7s changed the title feat: temp trying to update providers feat: upgrade @metamask/providers to v22.1.0 May 2, 2025
Copy link

sonarqubecloud bot commented May 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.4% Coverage on New Code (required ≥ 80%)
11.5% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template team-sdk SDK team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants