-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: Add max value refresher for transfer
redesigned confirmations
#15074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not going to add any test for this file since it just does the animation - we may ask for some reusable component from DS as described here #13117
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15074 +/- ##
==========================================
- Coverage 67.84% 67.78% -0.07%
==========================================
Files 2343 2346 +3
Lines 50476 50678 +202
Branches 7452 7497 +45
==========================================
+ Hits 34246 34351 +105
- Misses 14062 14143 +81
- Partials 2168 2184 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Description
This PR aims to add max value refresher hook into
transfer
confirmations.Essentially hook is updating transaction value via
updateEditableParams
. After design discussions - every update should pulse theTokenHero
component. Hence this PR also movesanimated-pulse
component in to UI components and re-use that.Regarding changes in
animated-pulse
: it appears ifisPulsing
changing too fast it stops animation. Hence there are modifications inanimated-pulse
component but it's basically making sure pulse animation at least done twice.Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4797
Manual testing steps
Only possible to test it out via setting
FEATURE_FLAG_REDESIGNED_TRANSFER
totrue
Screenshots/Recordings
Before
After
max.value.update.pulse.mp4
Pre-merge author checklist
Pre-merge reviewer checklist