Skip to content

Conversation

@OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented May 2, 2025

Description

This PR aims to add max value refresher hook into transfer confirmations.

Essentially hook is updating transaction value via updateEditableParams. After design discussions - every update should pulse the TokenHero component. Hence this PR also moves animated-pulse component in to UI components and re-use that.

Regarding changes in animated-pulse: it appears if isPulsing changing too fast it stops animation. Hence there are modifications in animated-pulse component but it's basically making sure pulse animation at least done twice.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4797

Manual testing steps

Only possible to test it out via setting FEATURE_FLAG_REDESIGNED_TRANSFER to true

Screenshots/Recordings

Before

After

max.value.update.pulse.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz added No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels May 2, 2025
@OGPoyraz OGPoyraz requested a review from a team as a code owner May 2, 2025 11:44
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label May 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e6f9a52
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/07ab2712-0537-45e4-a570-201176277575

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9366295
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7012197a-6b31-45db-8066-6296387a8430

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2025

Codecov Report

Attention: Patch coverage is 87.05882% with 11 lines in your changes missing coverage. Please review.

Project coverage is 68.72%. Comparing base (5113000) to head (b4414ef).
Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
...ns/components/UI/animated-pulse/animated-pulse.tsx 80.48% 6 Missing and 2 partials ⚠️
...text/confirmation-context/confirmation-context.tsx 81.81% 1 Missing and 1 partial ⚠️
.../Views/confirmations/hooks/useMaxValueRefresher.ts 95.65% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15074      +/-   ##
==========================================
+ Coverage   68.46%   68.72%   +0.26%     
==========================================
  Files        2372     2384      +12     
  Lines       51275    51517     +242     
  Branches     7634     7683      +49     
==========================================
+ Hits        35103    35405     +302     
+ Misses      13942    13860      -82     
- Partials     2230     2252      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OGPoyraz OGPoyraz requested a review from digiwand May 13, 2025 10:40
@github-actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: dc08bc9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dc657932-09e6-4136-b78f-08d711bb4cc7

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b4414ef
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/eeff78d8-02f8-4941-a260-58867842ba1b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@OGPoyraz OGPoyraz enabled auto-merge May 13, 2025 18:55
@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0e6fbda
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0559d6c1-590c-4f76-98b5-67ab66f04acd

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

@OGPoyraz OGPoyraz disabled auto-merge May 14, 2025 03:56
@OGPoyraz OGPoyraz added this pull request to the merge queue May 14, 2025
Merged via the queue into main with commit acfbd30 May 14, 2025
43 of 44 checks passed
@OGPoyraz OGPoyraz deleted the ogp/4797 branch May 14, 2025 04:21
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.48.0 Issue or pull request that will be included in release 7.48.0 team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants