-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: Add max value refresher for transfer redesigned confirmations
#15074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
app/components/Views/confirmations/components/UI/animated-pulse/animated-pulse.tsx
Show resolved
Hide resolved
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15074 +/- ##
==========================================
+ Coverage 68.46% 68.72% +0.26%
==========================================
Files 2372 2384 +12
Lines 51275 51517 +242
Branches 7634 7683 +49
==========================================
+ Hits 35103 35405 +302
+ Misses 13942 13860 -82
- Partials 2230 2252 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
app/components/Views/confirmations/components/UI/animated-pulse/animated-pulse.tsx
Show resolved
Hide resolved
app/components/Views/confirmations/components/UI/animated-pulse/animated-pulse.tsx
Outdated
Show resolved
Hide resolved
app/components/Views/confirmations/components/UI/animated-pulse/animated-pulse.tsx
Show resolved
Hide resolved
app/components/Views/confirmations/components/UI/animated-pulse/animated-pulse.tsx
Outdated
Show resolved
Hide resolved
app/components/Views/confirmations/components/UI/animated-pulse/animated-pulse.tsx
Show resolved
Hide resolved
app/components/Views/confirmations/hooks/useMaxValueRefresher.ts
Outdated
Show resolved
Hide resolved
|
|
|
|



Description
This PR aims to add max value refresher hook into
transferconfirmations.Essentially hook is updating transaction value via
updateEditableParams. After design discussions - every update should pulse theTokenHerocomponent. Hence this PR also movesanimated-pulsecomponent in to UI components and re-use that.Regarding changes in
animated-pulse: it appears ifisPulsingchanging too fast it stops animation. Hence there are modifications inanimated-pulsecomponent but it's basically making sure pulse animation at least done twice.Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4797
Manual testing steps
Only possible to test it out via setting
FEATURE_FLAG_REDESIGNED_TRANSFERtotrueScreenshots/Recordings
Before
After
max.value.update.pulse.mp4
Pre-merge author checklist
Pre-merge reviewer checklist