Skip to content

fix: cp-7.46.0 add navigation to activity page before solana tx submission #15082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2025
Merged

fix: cp-7.46.0 add navigation to activity page before solana tx submission #15082

merged 2 commits into from
May 3, 2025
+7 −0

Conversation

bfullam
Copy link
Contributor

@bfullam bfullam commented May 2, 2025 •
edited
Loading

Description

Navigate to activity tab before solana tx submission to ensure submission state doesn't get stuck.

Related issues

Fixes:

Manual testing steps

  1. Go to swaps
  2. Get quote
  3. Click "continue"
  4. Get navigated to activity page before snap is confirmed

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bfullam bfullam requested a review from a team as a code owner May 2, 2025 17:35
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bfullam bfullam added no-changelog Indicates no external facing user changes, therefore no changelog documentation needed No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise labels May 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ea0dfb4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3e512bdf-a8dc-41c3-8a90-51c199667c61

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
71.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bfullam bfullam added this pull request to the merge queue May 3, 2025
Merged via the queue into main with commit 471db71 May 3, 2025
40 checks passed
@bfullam bfullam deleted the fix-cp-7.46.0-add-navigation-to-activity-tab-before-solana-tx branch May 3, 2025 11:50
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amitabh94 amitabh94 amitabh94 approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.47.0 Issue or pull request that will be included in release 7.47.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-swaps-and-bridge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bfullam @amitabh94 @metamaskbot