Skip to content

fix: cp-7.46.0 show "auto" when slippage is undefined #15083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 3, 2025

Conversation

bfullam
Copy link
Contributor

@bfullam bfullam commented May 2, 2025

Description

Shows "Auto" as the slippage text on Solana swaps when the slippage is undefined. This case is for LiFi so it uses their dynamic slippage.

Related issues

Fixes:

Manual testing steps

  1. Go to this solana swap
  2. Get quotes
  3. See "Auto" as slippage value

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bfullam bfullam requested a review from a team as a code owner May 2, 2025 17:39
Copy link
Contributor

github-actions bot commented May 2, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bfullam bfullam added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed If the PR does not need E2E smoke test run labels May 2, 2025
@bfullam bfullam added this pull request to the merge queue May 3, 2025
Merged via the queue into main with commit 03fd913 May 3, 2025
40 checks passed
@bfullam bfullam deleted the mms-2340-fix-undefined-slippage branch May 3, 2025 11:50
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.47.0 Issue or pull request that will be included in release 7.47.0 team-swaps-and-bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants