chore: Bump Snaps packages #15232

Mrtenz · 2025-05-08T10:43:19Z

Description

This bumps Snaps packages to the latest versions. The main changes are:

Support for snap_trackEvent.
The execution environment is now built with @lavamoat/webpack, resulting in a smaller bundle.
Several small performance optimisations and fixes.

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

socket-security · 2025-05-08T10:46:38Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Quality	Maintenance
npm/@metamask/snaps-utils@9.2.1 ⏵ 9.2.2
npm/@metamask/snaps-rpc-methods@12.1.0 ⏵ 12.2.0		⁺¹	⁺¹
npm/@metamask/snaps-controllers@11.2.3 ⏵ 12.0.0			^-1
npm/@metamask/snaps-execution-environments@7.2.2 ⏵ 8.0.1
npm/@metamask/snaps-sdk@6.22.1 ⏵ 6.23.0	⁺¹	⁺¹
npm/@metamask/post-message-stream@9.0.0 ⏵ 10.0.0	⁺¹
npm/@metamask/providers@22.0.1 ⏵ 22.1.0			^-1

View full report

github-actions · 2025-05-08T10:55:19Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e5ac49c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/de00b23a-4026-4da9-a6e5-1aac88d6092f

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-05-08T12:09:40Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ad064e3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7fbb3c3f-2dcf-4723-9bf7-527906cac1b0

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2025-05-13T07:57:03Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…14428) ## **Description** This PR adds MetaMetrics tracking hook to Snap controller init. This way we delegate Snap export tracking to Snap controller. ## **Related issues** Related PR: MetaMask/snaps#3281 MetaMask/metamask-extension#31553 ## **Notes** - Requires Snaps release. - Snaps PR: MetaMask/snaps#3281 - Targets Snaps release when ready. ## **Manual testing steps** 1. TBD ## **Screenshots/Recordings** ### **Before** n/a ### **After** n/a ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description** Add integration for new RPC method: `snap_trackEvent` SIP-32: https://metamask.github.io/SIPs/SIPS/sip-32 Related PRs: - Snaps: MetaMask/snaps#3375 - Extension: MetaMask/metamask-extension#32554 ## **Related issues** MetaMask/snaps#3274 ## **Manual testing steps** 1. Within some of the preinstalled Snaps use `snap_trackEvent` RPC method and send some tracking data in format specified in [SIP-32](https://metamask.github.io/SIPs/SIPS/sip-32). 2. Find a way and verify that the event is sent (intercept MetaMetrics track event method or check with other e2e metrics testing utilities) Example Snap code used for testing the method: ```typescript await snap.request({ method: 'snap_trackEvent', params: { event: { event: 'SnapExportUsed', properties: { export: 'onRpcRequest', origin: 'https://metamask.io', snap_category: null, snap_id: 'npm:@metamask/example-snap', success: true, }, sensitiveProperties: { transaction_hash: 'transaction-hash', }, }, }, }); ``` ## **Screenshots/Recordings** ### **Before** n/a ### **After** n/a ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

socket-security · 2025-05-13T08:26:41Z

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

npm/@metamask/[email protected]

View full report

codecov-commenter · 2025-05-13T08:44:58Z

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.67%. Comparing base (5113000) to head (e90e1d4).
Report is 27 commits behind head on main.

Files with missing lines	Patch %	Lines
...e/Engine/controllers/snaps/snap-controller-init.ts	0.00%	1 Missing ⚠️
app/core/Snaps/SnapsMethodMiddleware.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15232      +/-   ##
==========================================
+ Coverage   68.46%   68.67%   +0.21%     
==========================================
  Files        2372     2378       +6     
  Lines       51275    51372      +97     
  Branches     7634     7652      +18     
==========================================
+ Hits        35103    35281     +178     
+ Misses      13942    13846      -96     
- Partials     2230     2245      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-05-13T08:59:49Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0cb2531
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/59f5cbf5-6116-4c42-ba51-c3da605905d9

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Mrtenz · 2025-05-13T09:44:02Z

@SocketSecurity ignore npm/@metamask/[email protected]

This is ours.

sonarqubecloud · 2025-05-13T09:57:11Z

Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

metamaskbot added the team-snaps-platform Snaps Platform team label May 8, 2025

Mrtenz added needs-qa Any New Features that needs a full manual QA prior to being added to a release. Run Smoke E2E Requires smoke E2E testing labels May 8, 2025

Mrtenz added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 8, 2025

metamaskbot added the bitrise-result-ready label May 8, 2025

github-actions bot removed the bitrise-result-ready label May 8, 2025

Mrtenz and others added 7 commits May 13, 2025 10:25

Bump Snaps packages

d27ce81

Deduplicate @metamask/post-message-stream

9a50756

Update post-message-stream patch

d19e959

Update webview execution environment path

06efb50

Bump snaps-execution-environments again

d95abf6

Mrtenz force-pushed the mrtenz/snaps-104 branch from a5c1d0e to e90e1d4 Compare May 13, 2025 08:25

Add test

0cb2531

Mrtenz added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 13, 2025

metamaskbot added the bitrise-result-ready label May 13, 2025

github-actions bot removed the bitrise-result-ready label May 13, 2025

FrederikBolding previously approved these changes May 13, 2025

View reviewed changes

Mrtenz marked this pull request as ready for review May 13, 2025 09:39

Mrtenz requested a review from a team as a code owner May 13, 2025 09:39

FrederikBolding added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label May 13, 2025

Add missing await

6faab39

Mrtenz dismissed FrederikBolding’s stale review via 6faab39 May 13, 2025 09:43

FrederikBolding approved these changes May 13, 2025

View reviewed changes

david0xd approved these changes May 13, 2025

View reviewed changes

Mrtenz removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label May 13, 2025

tommasini approved these changes May 13, 2025

View reviewed changes

Mrtenz added this pull request to the merge queue May 13, 2025

Merged via the queue into main with commit 8f1f519 May 13, 2025
40 of 43 checks passed

Mrtenz deleted the mrtenz/snaps-104 branch May 13, 2025 12:07

github-actions bot locked and limited conversation to collaborators May 13, 2025

metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Bump Snaps packages #15232

chore: Bump Snaps packages #15232

Mrtenz commented May 8, 2025

socket-security bot commented May 8, 2025 •

edited

Loading

github-actions bot commented May 8, 2025 •

edited by metamaskbot

Loading

github-actions bot commented May 8, 2025 •

edited by metamaskbot

Loading

github-actions bot commented May 13, 2025

socket-security bot commented May 13, 2025 •

edited

Loading

codecov-commenter commented May 13, 2025

github-actions bot commented May 13, 2025 •

edited by metamaskbot

Loading

Mrtenz commented May 13, 2025

sonarqubecloud bot commented May 13, 2025

chore: Bump Snaps packages #15232

chore: Bump Snaps packages #15232

Conversation

Mrtenz commented May 8, 2025

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

socket-security bot commented May 8, 2025 • edited Loading

github-actions bot commented May 8, 2025 • edited by metamaskbot Loading

Bitrise

github-actions bot commented May 8, 2025 • edited by metamaskbot Loading

Bitrise

github-actions bot commented May 13, 2025

socket-security bot commented May 13, 2025 • edited Loading

codecov-commenter commented May 13, 2025

Codecov Report

github-actions bot commented May 13, 2025 • edited by metamaskbot Loading

Bitrise

Mrtenz commented May 13, 2025

sonarqubecloud bot commented May 13, 2025

Quality Gate failed

socket-security bot commented May 8, 2025 •

edited

Loading

github-actions bot commented May 8, 2025 •

edited by metamaskbot

Loading

github-actions bot commented May 8, 2025 •

edited by metamaskbot

Loading

socket-security bot commented May 13, 2025 •

edited

Loading

github-actions bot commented May 13, 2025 •

edited by metamaskbot

Loading