You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The storage write debounce has been replaced with the redux-persist option throttle. This option has the advantage of applying to state serialization as well as writing, so we avoid frequent expensive serialization. Using throttle instead of debounce also guarantees a write every so often during periods of rapid state updates, ensuring the application doesn't go too long without persisting.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
The storage write debounce has been replaced with the `redux-persist`
option `throttle`. This option has the advantage of applying to state
serialization as well as writing, so we avoid frequent expensive
serialization. Using `throttle` instead of `debounce` also guarantees
a write every so often during periods of rapid state updates, ensuring
the application doesn't go too long without persisting.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tommasini
added
needs-dev-review
github-project-automation
bot
moved this from Needs dev review
to Review finalised - Ready to be merged
in PR review queue
The storage write debounce has been replaced with the
redux-persistoptionthrottle. This option has the advantage of applying to state serialization as well as writing, so we avoid frequent expensive serialization. Usingthrottleinstead ofdebouncealso guarantees a write every so often during periods of rapid state updates, ensuring the application doesn't go too long without persisting.Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist