Skip to content

feat(INFRA-2531): check for bitrise success comments in imported commits #15349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2025

Conversation

makemesteaks
Copy link
Member

#15154

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-dev-ops DevOps team label May 15, 2025
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 15, 2025
@makemesteaks makemesteaks force-pushed the infra-2531-e2e-check branch from f3941d5 to f5b091b Compare May 15, 2025 09:04
@makemesteaks makemesteaks added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed If the PR does not need E2E smoke test run bitrise-result-ready and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels May 15, 2025
@makemesteaks makemesteaks added Run Smoke E2E Requires smoke E2E testing and removed No E2E Smoke Needed If the PR does not need E2E smoke test run labels May 15, 2025
Copy link
Contributor

github-actions bot commented May 15, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 76c795e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/251515fd-cd92-4a08-a1ee-748abfa56878

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@tommasini tommasini added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 15, 2025
Copy link
Contributor

github-actions bot commented May 15, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c7c5dc3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0375c110-b3a5-4e8d-960d-884733042d50

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 15, 2025
@makemesteaks makemesteaks requested a review from Cal-L May 15, 2025 20:01
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@makemesteaks makemesteaks added this pull request to the merge queue May 20, 2025
Merged via the queue into main with commit 7cca5bb May 20, 2025
40 checks passed
@makemesteaks makemesteaks deleted the infra-2531-e2e-check branch May 20, 2025 10:11
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.48.0 Issue or pull request that will be included in release 7.48.0 Run Smoke E2E Requires smoke E2E testing team-dev-ops DevOps team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants