chore: Use metro extraNodeModules instead of rn-nodeify

[Cal-L]

Description

This PR removes rn-nodeify in favor of the more modern extraNodeModules field in metro for React Native. This provides a bit of a cleaner interface to work with and doesn't require mutation of node_modules
Reference - https://gist.github.com/parshap/e3063d9bf6058041b34b26b7166fd6bd#metroconfigjs-and-extranodemodules

Related issues

Fixes:

Manual testing steps

App should still function as normally. Ex. To confirm crypto polyfill, console log the import of crypto and notice that it should match react-native-crypto, which we're using to fill crypto

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[Cal-L]

This should be replaced with react-native-quick-crypto if we can

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4e8ff38
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/efcacad6-afc5-4aa1-8db6-0caa30b65993

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud