Skip to content

feat: add feature flag env var #15414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented May 16, 2025

Description

Currently the LaunchDarkly environment are coupled with a METAMASK_ENVIRONMENT value, which is used across the app. This makes impossible to customize the LD environment for manual builds (for example, a Flask builds that points to Production LD).

This PR introduces FEATURE_FLAG_ENVIRONMENT optional env var that can be set on bitrise to set a custom LD env.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-ramp issues related to Ramp features label May 16, 2025
@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Requires smoke E2E testing labels May 16, 2025
@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue May 16, 2025
@wachunei wachunei marked this pull request as ready for review May 16, 2025 18:32
@wachunei wachunei requested a review from a team as a code owner May 16, 2025 18:32
Copy link
Contributor

github-actions bot commented May 16, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 492e5a6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/813063a8-4376-4725-93b4-e708553a1d7d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@wachunei wachunei changed the title feature: add feature flag env var feat: add feature flag env var May 16, 2025
@wachunei wachunei added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Requires smoke E2E testing team-ramp issues related to Ramp features
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

2 participants