chore: Batch bg state updates in Engine service (#15189)

[Cal-L]

Description

Changes are from Stas from Margelo from the original PR here - #15189

Some information describing the changes #15189 (comment)

• usage of unstable_batchedUpdates - state updates triggered outside of React event handlers - such as within a setTimeout callback (debounce uses setTimeout under the hood) - are not automatically batched, so each dispatch would normally trigger its own rerender, so usage of unstable_batchedUpdates ensures that multiple redux actions flush result in a single render pass
• setTimeout vs debounce - it was already mentioned in perf: Debounce and group state updates being flushed to Redux #14927 (comment) that if events keep coming in faster than the delay (constant background updates), a debounced flush may never occur, and that results in no UI updates. The setTimeout approach ensured a flush at least once per interval. Additionally, the setTimeout approach avoids pulling in an external dependency.
  also this pr introduces fewer changes, and the Batcher class might be reused in other places to batch updates

Related issues

Fixes: #15028 #15560

Manual testing steps

1. Go to this page... 2.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding
  Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you all read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

1 out of 2 committers have signed the CLA.
✅ @Cal-L
❌ @stas-kravchuk

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 78b9a94
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fa63ff3b-e78a-4a1b-bcdf-dd375430013e

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 26.08696% with 17 lines in your changes missing coverage. Please review.

Project coverage is 68.89%. Comparing base (c62b042) to head (98342cd).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
app/core/EngineService/EngineService.ts	26.08%	17 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15416      +/-   ##
==========================================
- Coverage   68.92%   68.89%   -0.03%     
==========================================
  Files        2394     2394              
  Lines       51403    51432      +29     
  Branches     7720     7727       +7     
==========================================
+ Hits        35430    35435       +5     
- Misses      13702    13726      +24     
  Partials     2271     2271              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate failed

Failed conditions
20.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 98342cd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0b7079a6-6166-469d-9724-fb2bd63150b9

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[Cal-L]

Performance test - https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/70687a78-a86c-4508-a2f9-c68193030e8a