Skip to content

feat: 15379 update minimum version modal UI #15567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: 15379 update minimum version modal UI #15567

wants to merge 1 commit into from

Conversation

weitingsun
Copy link

@weitingsun weitingsun commented May 22, 2025 •
edited
Loading

Description

Update updates needed UI on mobile:

  • Remove Remind me later secondary cta
  • Add X close button on top right of the screen, should have the same behavior of existing Remind me later
  • Add MetaMask name logo on top
  • Replace image and copy

Related issues

Fixes: #15379

Manual testing steps

  1. Run locally
  2. Go to the file "useMinimumVersions.tsx" and flip the boolean shouldTriggerUpdateFlow in useEffect to trigger the modal
  3. Refresh the app
  4. Should see the update modal pops up

Screenshots/Recordings

Before

Android beforeiOS before

After

Android afteriOS after

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 22, 2025 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@weitingsun
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@weitingsun weitingsun self-assigned this May 22, 2025
@weitingsun weitingsun added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 22, 2025
@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue May 22, 2025
@weitingsun weitingsun added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Requires smoke E2E testing labels May 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 22, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8381e45
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/172d9441-bca9-4fd2-8e7d-ac0211dae2bf

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@weitingsun weitingsun added the team-mobile-platform Mobile Platform team label May 23, 2025
@weitingsun weitingsun force-pushed the feat/15379-update-minimum-version-workflow-to-increase-user-adoption branch 2 times, most recently from cb6f621 to fccbd5b Compare May 23, 2025 18:01
@weitingsun weitingsun added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 23, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: fccbd5b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0b59d4f5-3b81-45a4-88e7-134666183ae2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@weitingsun weitingsun force-pushed the feat/15379-update-minimum-version-workflow-to-increase-user-adoption branch from fccbd5b to b5c4f31 Compare May 23, 2025 18:54
@weitingsun weitingsun added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 23, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b5c4f31
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f2a95390-a7fb-4328-a5cf-c6acca9a9d6d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sethkfman
sethkfman reviewed May 23, 2025
View reviewed changes
app/components/UI/UpdateNeeded/UpdateNeeded.test.tsx
const { toJSON } = renderScreen(
UpdateNeeded,
{ name: 'UpdateNeeded' },
{ state: {} },
);
expect(toJSON()).toMatchSnapshot();
});
it('should render correctly', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great test addition.

sethkfman
sethkfman approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue May 23, 2025
@weitingsun weitingsun added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 23, 2025
@weitingsun weitingsun marked this pull request as ready for review May 24, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees

@weitingsun weitingsun

Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Requires smoke E2E testing team-mobile-platform Mobile Platform team
Projects
PR review queue
Status: Review finalised - Ready to be merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update minimum version workflow to increase user adoption.
3 participants
@weitingsun @sethkfman @metamaskbot