-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: Popular tokens display #16027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Popular tokens display #16027
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
…o zs/discovery-display
|
|
|
MarioAslau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@MetaMask/swaps-engineers would you please take a look at this PR? I think it's tagging you because there are changes to |
| // The await above isn't enough for the network to actually be set | ||
| await waitForCondition({ | ||
| fn: () => selectChainId(store.getState()) === swapToken.chainId, | ||
| timeout: 2000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the 2000 timeout value guaranteed to provide deterministic results, or is it something that might need to be adjusted again in the future? Also, how did we arrive at this specific number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if this line is removed? Because we've been using this code without this waitForCondition before.



Description
This PR changes the behaviour of the "Discover" tab (4th button in the bottom bar) in the following ways:
Three smaller PRs have been merged into this one after being reviewed and approved by @MarioAslau :
useSwapBridgeNavigation, where the multichain network controller returns before the chain is actually changedRelated issues
Fixes: MMPD-1590
Manual testing steps
Screenshots/Recordings
Before
Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-05-28.at.17.57.16.mp4
After
discovery.mp4
Pre-merge author checklist
Pre-merge reviewer checklist