Skip to content

Cherry-pick aa1ba84 in to 7.49.0#16126

Merged
NicolasMassart merged 2 commits into
release/7.49.0from
release/7.49.0-aa1ba84
Jun 5, 2025
Merged

Cherry-pick aa1ba84 in to 7.49.0#16126
NicolasMassart merged 2 commits into
release/7.49.0from
release/7.49.0-aa1ba84

Conversation

@OGPoyraz
Copy link
Copy Markdown
Member

@OGPoyraz OGPoyraz commented Jun 5, 2025

This PR cherry-picks aa1ba84

PR: #16117

…16117)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This chore PR has no functional changes - just renames row component to
have "row" in their names to make it more explicit.

## **Related issues**

Fixes: N/A

## **Manual testing steps**

N/A

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@OGPoyraz OGPoyraz requested a review from a team as a code owner June 5, 2025 10:25
@metamaskbot metamaskbot added team-confirmations Push issues to confirmations team INVALID-PR-TEMPLATE PR's body doesn't match template labels Jun 5, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5bd2677
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/97839a71-1274-4aab-8878-0ab45e4dfd89

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@OGPoyraz
Copy link
Copy Markdown
Member Author

OGPoyraz commented Jun 5, 2025

@metamaskbot update-attributions

@metamaskbot
Copy link
Copy Markdown
Collaborator

Attributions updated

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 5, 2025

@NicolasMassart NicolasMassart merged commit 3b6eed2 into release/7.49.0 Jun 5, 2025
38 of 43 checks passed
@NicolasMassart NicolasMassart deleted the release/7.49.0-aa1ba84 branch June 5, 2025 14:45
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants