-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: restrict commit message for running release builds #20785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| echo "BITRISE_GIT_MESSAGE: $BITRISE_GIT_MESSAGE" | ||
| if ! echo "$BITRISE_GIT_MESSAGE" | grep -q "\[skip ci\] Bump version | ||
| number to"; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions. |



Description
Summary
Add validation to ensure release builds only proceed with correct commit message format.
Changes
check_release_commit_messagethat validates commit messages contain the expected pattern[skip ci] Bump version number tobuild_android_rc_and_upload_sourcemapsandbuild_ios_rc_and_upload_sourcemaps)Technical Details
BITRISE_GIT_MESSAGEenvironment variable to check the commit messagegrep -qto perform pattern matching without outputset -eandset -o pipefailset -xPurpose
This change helps prevent accidental release builds by ensuring only commits with the proper version bump message format trigger the release workflow, improving CI/CD reliability and preventing unintended releases.
Files Modified
bitrise.yml- Added commit message validation workflow stepCommit:
797ced05a2- added check to fail release build if it doesn't contain the correct commit numberChangelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Testing
Expected PASS
Expected FAIL
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Enforces a commit-message check before release builds and bumps all build numbers to 2649 across CI and iOS project configs.
check_release_commit_messageworkflow to validateBITRISE_GIT_MESSAGEmatches[skip ci] Bump version number toand fail with guidance otherwise.build_android_release_and_upload_sourcemapsandbuild_ios_release_and_upload_sourcemaps.VERSION_NUMBERandFLASK_VERSION_NUMBERinbitrise.ymlto2649.CURRENT_PROJECT_VERSIONto2649acrossMetaMask,MetaMask-Flask, andMetaMask-QAconfigurations inios/MetaMask.xcodeproj/project.pbxproj.Written by Cursor Bugbot for commit 2bbba2d. This will update automatically on new commits. Configure here.