-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
test: add MM Connect Wagmi and EVM Appwright E2E tests #21978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 101 commits
b3c6d7a
a9e2714
656d2f4
6a53d0e
5068730
e4583f0
11f9e9b
4d25abc
299e18a
a813317
1f6966d
f3a814b
88d0150
1c9bfac
6bb6b85
a7a6cfb
fe47584
a215806
55b0b84
d57bc6b
942f9ed
b0c4922
d047fc7
e85e0e9
499bf03
8f86c58
750d57c
e74317a
b8ded40
53cdb29
36655f0
2bf2d97
e9fec7b
6dcfb5f
97f9c08
b72973b
bd71743
a81a4e5
47384c1
34b1d7c
73fdcc3
ac94c35
7711f17
c46593f
109d645
1f470c0
4d4899c
91f5e5b
0ec6ac1
d4d9377
88762e1
e88ef25
0094d72
458f675
0488a31
c05fc5b
c0d5255
bc35cf4
8863dee
56de948
86cd581
7601d0a
3eb24da
20b9d44
9ba6a97
716c410
3f02bfd
a5e394b
832ab3b
0660ed9
717a3b6
ac7e3d3
a5e8bfd
96b5c68
c52a0d7
8899965
8f7bf84
c24cb5c
5bbb370
7fd664f
e36fd96
f92070d
ac31aab
90cff1f
3ef31bb
4d24a32
6c173e7
e024877
d911349
4a5045b
4681da9
1c69714
b3eb0a3
845fd30
4e72599
0e13bd4
76a90d2
40ac707
e5164a4
5766e7e
837ff23
7b63562
a9c0340
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| diff --git a/dist/providers/appium.js b/dist/providers/appium.js | ||
| index 2d8e8924124b882d44ab0aa11fede4d4094b7a65..56f8e4e5d4b3863a903935512be14d224aa854a1 100644 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why do we need this patch ?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixes an issue where the appropriate web driver isn't automatically downloaded if not already installed on your machine
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @christopherferreira9 do we need to keep this around?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes otherwise switching between web and native context will not be possible |
||
| --- a/dist/providers/appium.js | ||
| +++ b/dist/providers/appium.js | ||
| @@ -43,7 +43,7 @@ async function installDriver(driverName) { | ||
| async function startAppiumServer(provider) { | ||
| let emulatorStartRequested = false; | ||
| return new Promise((resolve, reject) => { | ||
| - const appiumProcess = (0, child_process_1.spawn)("npx", ["appium"], { | ||
| + const appiumProcess = (0, child_process_1.spawn)("npx", ["appium", "--allow-insecure=chromedriver_autodownload"], { | ||
| stdio: "pipe", | ||
| }); | ||
| appiumProcess.stderr.on("data", async (data) => { | ||
| diff --git a/dist/providers/browserstack/index.js b/dist/providers/browserstack/index.js | ||
| index 61ecd1508400f59302d6139a805e7a912e9a1036..09bf83155b64b4bcf86ce8684efe36e0f9923adb 100644 | ||
| --- a/dist/providers/browserstack/index.js | ||
| +++ b/dist/providers/browserstack/index.js | ||
| @@ -275,6 +275,8 @@ class BrowserStackDeviceProvider { | ||
| "appium:settings[actionAcknowledgmentTimeout]": 3000, | ||
| "appium:settings[ignoreUnimportantViews]": true, | ||
| "appium:settings[waitForSelectorTimeout]": 10000, | ||
| + "appium:includeSafariInWebviews": true, | ||
| + "appium:chromedriverAutodownload": true, | ||
| }, | ||
| }; | ||
| } | ||
| diff --git a/dist/providers/emulator/index.js b/dist/providers/emulator/index.js | ||
| index f3bc1502e7aa9d59b99a915adcbba5e13928e413..cd23dbfde74274fa90d664cadc4b60c8ceee8d74 100644 | ||
| --- a/dist/providers/emulator/index.js | ||
| +++ b/dist/providers/emulator/index.js | ||
| @@ -77,6 +77,8 @@ Follow the steps mentioned in ${androidSimulatorConfigDocLink} to run test on An | ||
| "appium:deviceOrientation": this.project.use.device?.orientation, | ||
| "appium:settings[snapshotMaxDepth]": 62, | ||
| "appium:wdaLaunchTimeout": 300_000, | ||
| + "appium:includeSafariInWebviews": true, | ||
| + "appium:chromedriverAutodownload": true, | ||
| }, | ||
| }; | ||
| } | ||
| diff --git a/dist/providers/local/index.js b/dist/providers/local/index.js | ||
| index dc394b0696dd67d259a03856c5b49dcb5820d0ad..38c9b1fcc7ec5b4256831be0bedca1bc712dc528 100644 | ||
| --- a/dist/providers/local/index.js | ||
| +++ b/dist/providers/local/index.js | ||
| @@ -79,6 +79,8 @@ To specify a device, use the udid property. Run "adb devices" to get the UDID fo | ||
| "appium:fullReset": true, | ||
| "appium:deviceOrientation": this.project.use.device?.orientation, | ||
| "appium:settings[snapshotMaxDepth]": 62, | ||
| + "appium:includeSafariInWebviews": true, | ||
| + "appium:chromedriverAutodownload": true, | ||
| }, | ||
| }; | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain this patch is necessary and whether we have plans to upstream the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christopherferreira9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replied here: https://github.com/MetaMask/metamask-mobile/pull/21978/files#r2674127734
The plan is to fully deprecate appwright (and the respective patches) for the in-house solution where the changes from this patch have already been applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I have to say something about the latest github update is making it very hard to see all the comments and follow what has already been addressed/resolved