chore(runway): cherry-pick chore: fix apr issue with znon-zero values cp-7.61.6

[runway-github]

• chore: fix apr issue with znon-zero values cp-7.61.6 (chore: fix apr issue with znon-zero values cp-7.61.6 #24248)

Description

Updated APR fallback logic from nullish coalescing (??) to check if
aprOverride is a valid non-zero value, preventing "0%" from overriding
a legitimate earnToken.experience.apr.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor
  Docs and MetaMask Mobile
  Coding
  Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format
  if applicable
• I’ve applied the right labels on the PR (see labeling
  guidelines).
  Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the
  app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described
  in the ticket it closes and includes the necessary testing evidence such
  as recordings and or screenshots.

---

Note

Adjusts APR display logic in getStakingNavbar for Tron staking.

• Use aprOverride only when its parsed numeric value is > 0; otherwise fall back to earnToken.experience.apr with one-decimal formatting and %
• Introduces parsedOverride helper to parse the override before deciding the source

^{Written by Cursor Bugbot for commit dfde6e9. This will update automatically on new commits. Configure here.}

541e3ad

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeStake
• Risk Level: low
• AI Confidence: 85%

click to see 🤖 AI reasoning details

The change is a minor enhancement to the Navbar component's getStakingNavbar function. Specifically:

1. What Changed:

   • Added an optional aprOverride parameter to the getStakingNavbar function
   • Modified the APR display logic to use the override value if provided (for Tron staking)
   • Changed the APR formatting to avoid double percentage signs when using override
   • This is wrapped in a BEGIN:ONLY_INCLUDE_IF(tron) conditional compilation block

2. Impact Analysis:

   • The change is limited to the display of APR (Annual Percentage Rate) in the staking navbar
   • The parameter is optional and defaults to null, so existing callers remain unaffected
   • No current code in the codebase passes this parameter yet (grep search showed no usage)
   • The function is used by various staking/earn views for navigation headers

3. Risk Assessment:

   • Low Risk: This is a purely UI display change with backward compatibility
   • Optional parameter with safe default handling
   • No logic changes to core functionality
   • Limited to conditional Tron-specific code block
   • Formatting fix prevents double percentage signs

4. Test Coverage Needed:

   • SmokeStake: Should be run to verify staking UI and navigation headers still work correctly
   • This is the most relevant tag as it covers staking features where this function is used

The change is isolated, backward-compatible, and only affects the visual display of APR values in staking-related screens. While it's a low-risk change, testing the staking flows will ensure the navbar displays correctly.

View GitHub Actions results

[sonarqubecloud]

Quality Gate failed

Failed conditions
77.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

[metamaskbot]

No release label on PR. Adding release label release-7.61.6 on PR, as PR was cherry-picked in branch 7.61.6.