chore(perps): Refactor HL subscription service (#24015)

[gambinish]

Description

This PR refactors the HyperLiquid subscription service to drop subscription fallbacks.

This refactor was raised during the offsite, as it is needed as a result of the hotfix we had to deploy to address Perps loading issue during the weekend. The initial PR
#23753 introduced a fallback mechanism that would create new subscriptions when the properties in the data coming from the old subscriptions were missing. Given that these properties will be always missing, this PR uses the new subscriptions as a default.

Source PR: #24015

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

No visible change

After

No visible change

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding
  Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Refactors HyperLiquid live data flow and improves TP/SL processing.

• Switches HIP-3 to individual per-DEX subscriptions: clearinghouseState (positions/account) and openOrders (orders); uses webData3 only for OI cap updates; removes fallback caches/subscriptions and updates cleanup/restore logic
• Enhances extractTPSLFromOrders to accept cached orders and classify ambiguous Trigger orders via price vs entry; re-extracts TP/SL on clearinghouseState updates to preserve UI state
• Adds triggerPrice to Order and sets it in adaptOrderFromSDK; price now falls back to triggerPx when limitPx is absent
• Test suite updates: adopt Jest fake timers (runAllTimersAsync), add mocks for new per-DEX subscriptions, and extend cases for TP/SL counts, cached rehydration, L2 book ref counting, reconnection, and error handling

^{Written by Cursor Bugbot for commit c58a7b1. This will update automatically on new commits. Configure here.}

---

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokePerps
• Risk Level: medium
• AI Confidence: 85%

click to see 🤖 AI reasoning details

The changes are entirely isolated to the Perps (Perpetuals) trading feature, specifically:

1. Scope of Changes: All 5 modified files are within app/components/UI/Perps/ directory:

   • Type definitions for order callbacks and order data structures
   • Major refactoring of WebSocket subscription service for multi-DEX support
   • Adapter improvements for trigger price handling
   • Comprehensive test updates

2. Nature of Changes:

   • Refactoring from monolithic webData3 subscription to individual clearinghouseState and openOrders subscriptions
   • Enhanced TP/SL (Take Profit/Stop Loss) data processing
   • Added isSnapshot parameter for order fill callbacks
   • Added triggerPrice field to orders for better UI display

3. Risk Level: Medium because:

   • This is a significant architectural change to the WebSocket subscription layer
   • Real-time data updates are critical for trading features
   • Changes affect position tracking, order updates, and fill notifications
   • However, changes are well-isolated within the Perps module

4. Test Tag Selection:

   • SmokePerps: This is the only relevant tag as all changes are Perps-specific
   • No other features are impacted (no core wallet, network, confirmation, or other trading changes)
   • The tag exists and has a clear description: "Perpetuals trading"

5. Important Notes:

   • Currently, no E2E tests are actually tagged with SmokePerps (checked e2e/specs/perps/*.ts files which use RegressionTrade tag)
   • The perps E2E specs exist (6 files in e2e/specs/perps/) but aren't using the SmokePerps tag yet
   • If SmokePerps tag has no associated tests, this selection will effectively skip E2E testing
   • However, the changes include comprehensive unit test updates that provide coverage

The changes don't affect any other wallet features, so only SmokePerps should be run if such tests exist.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[cursor]

Mock missing triggerPrice masks TP/SL test coverage (Bugbot Rules)

Low Severity

Violates the testing rule "Use realistic mock data that reflects real usage." The adaptOrderFromSDK mock doesn't include triggerPrice, but the real implementation sets order.triggerPrice = rawOrder.triggerPx when triggerPx exists. The production code at line 390 uses order.triggerPrice || order.price for TP/SL extraction from cached orders. Tests pass coincidentally because test data uses identical limitPx and triggerPx values, making the fallback to price produce correct results. If test data had limitPx != triggerPx (as real Take Profit Limit orders do), the mock would return wrong TP/SL prices. The mock should include triggerPrice: order.triggerPx || undefined to match the real adapter behavior.

 

[metamaskbot]

No release label on PR. Adding release label release-7.61.6 on PR, as PR was added to branch 7.61.6 when release was cut.