Skip to content

Conversation

@vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Jan 7, 2026

Description

refine import account screen UI

Changelog

CHANGELOG entry:null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MDP-323

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

before after
before after

Before

~

After

~

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Modernizes the Import Private Key UI while preserving behavior.

  • Replaces ButtonIcon close control with HeaderCenter back header (testID preserved) and removes decorative download icon
  • Adjusts layout and spacing: adds marginTop, switches to paddingHorizontal, reduces row gaps, and centers scan-QR link row
  • Updates typography/colors: body text uses TextColor.Alternative; input uses background.section, muted text color, and tighter margins
  • Cleans up styles (removes background tints) and updates snapshots; import/scan flows and logic remain unchanged

Written by Cursor Bugbot for commit 75cc51b. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-ux Mobile UX team label Jan 7, 2026
@github-actions github-actions bot added the size-S label Jan 7, 2026
@vinnyhoward vinnyhoward enabled auto-merge January 8, 2026 16:57
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts
  • Risk Level: low
  • AI Confidence: 80%
click to see 🤖 AI reasoning details

The changes are purely UI/styling refactoring for the ImportPrivateKey component:

  1. Visual changes only: Replaced ButtonIcon with HeaderCenter component, removed Download icon, changed text colors from Default to Alternative, and adjusted spacing/margins in styles.

  2. No functional changes: The core functionality of importing accounts via private key remains unchanged. The component still uses the same Authentication.importAccountFromPrivateKey method and navigation flow.

  3. No direct E2E test coverage: My investigation found that while selectors exist (ImportAccountFromPrivateKey.selectors.ts), there are no E2E specs that actually use them. The import private key flow is not covered by existing E2E tests.

  4. Low risk assessment:

    • Pure styling/UI refactoring
    • No changes to business logic
    • Snapshot tests updated to reflect new UI
    • Unit tests exist and were updated

Selecting SmokeAccounts as it covers account management functionality, which is the domain this component belongs to. This provides general coverage for account-related flows even though the specific ImportPrivateKey UI may not be directly tested.

View GitHub Actions results

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Image

@vinnyhoward vinnyhoward added this pull request to the merge queue Jan 9, 2026
Merged via the queue into main with commit 1487a9c Jan 9, 2026
126 of 127 checks passed
@vinnyhoward vinnyhoward deleted the chore-mdp-323-update-import-account-screen branch January 9, 2026 21:05
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2026
@metamaskbot metamaskbot added the release-7.62.0 Issue or pull request that will be included in release 7.62.0 label Jan 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.62.0 Issue or pull request that will be included in release 7.62.0 size-S team-mobile-ux Mobile UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants