-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: Update headers for Accounts flow #24306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…to header/accounts
…to header/accounts
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…to header/accounts
…to header/accounts
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsThis PR is a UI refactoring that updates several components to use new header components (HeaderWithTitleLeft and HeaderCenter) from the component library. The changes affect:
The E2E test page object change (ImportSrpView.ts) removes platform-specific logic for the import button selector, which could affect test reliability. The tests that use this page object are:
Selected tags:
The changes are primarily visual/layout changes with no functional logic changes, but since they affect critical user flows (account selection, SRP import, private key import), running these smoke tests ensures the UI changes don't break the user experience. |
| testID={ImportAccountFromPrivateKeyIDs.CLOSE_BUTTON} | ||
| <View testID={ImportAccountFromPrivateKeyIDs.CONTAINER}> | ||
| <HeaderWithTitleLeft | ||
| includesTopInset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double top inset padding on iOS in ImportPrivateKey
Medium Severity
The includesTopInset prop is set to true on HeaderWithTitleLeft, but the component is already wrapped in a SafeAreaView from react-native (line 148) which automatically applies top safe area insets on iOS. This causes double top padding on iOS devices. The includesTopInset prop should be removed or set to false since the parent SafeAreaView already handles the top inset. This issue was also flagged in the PR review.
|


Description
This PR updates the header and footer styling across account-related screens to align with the new design system patterns. The changes migrate multiple screens from legacy navigation headers to the new
HeaderWithTitleLeftandHeaderCentercomponents fromcomponent-library/components-temp.Screens updated:
HeaderCenterfor consistent bottom sheet header styling with a close buttonHeaderWithTitleLeftwith proper back/scan button propsHeaderWithTitleLeftwith subtitle supportHeaderWithTitleLeftand replaced rawTextInputwithTextFieldcomponentHeaderCentercomponent and updated button variant from Primary to SecondaryAdditional improvements:
TextColor.Alternativefor subtitle/description textChangelog
CHANGELOG entry: Updated header and footer styling across account management screens to align with new design system
Related issues
Fixes: https://consensyssoftware.atlassian.net/jira/software/c/projects/MDP/boards/2972?assignee=62afb43d33a882e2be47c36f&quickFilter=3325&selectedIssue=MDP-322
https://consensyssoftware.atlassian.net/jira/software/c/projects/MDP/boards/2972?assignee=62afb43d33a882e2be47c36f&quickFilter=3325&selectedIssue=MDP-324
Manual testing steps
Screenshots/Recordings
Before
After
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2026-01-07.at.22.06.09.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Aligns account flows with the new design system headers and spacing.
HeaderCenter(bottom sheets) andHeaderWithTitleLeft(full screens) inAccountSelector,ImportNewSecretRecoveryPhrase,SelectHardware,ImportPrivateKey, andSeedphraseModal; adds close/back/scan actions via header propsTextColor.Alternativeto subtitles/descriptionsSeedphraseModal: new centered header, adjusted content spacing, bullet sizing, and "Got it" button toSecondaryImportNewSecretRecoveryPhrase: removes navbar config, adds header with back/QR actions, swaps to component-libraryButton, integratesButtonIconfor info, and updates stylesImportPrivateKey: migrates to new header with subtitle + learn-more, modernizes input styling/placeholder, and disables submit while loadingSrpInputGrid/styles: minor spacing tweaks (remove extra top margin)Written by Cursor Bugbot for commit c4042fb. This will update automatically on new commits. Configure here.