Skip to content

Conversation

@juanmigdr
Copy link
Member

@juanmigdr juanmigdr commented Jan 8, 2026

Description

Fix trending search not getting market data

Changelog

CHANGELOG entry: fix trending search not getting market data

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-2229

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Ensures trending-related searches return market data.

  • Adds optional includeMarketData to useSearchRequest and forwards it to searchTokens
  • Updates useTrendingSearch to call useSearchRequest with includeMarketData: true
  • Includes includeMarketData in useSearchRequest effect dependencies

Written by Cursor Bugbot for commit ce328cd. This will update automatically on new commits. Configure here.

@juanmigdr juanmigdr marked this pull request as ready for review January 8, 2026 11:53
@github-actions github-actions bot added the size-S label Jan 8, 2026
@juanmigdr juanmigdr enabled auto-merge January 8, 2026 11:53
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAssets
  • Risk Level: low
  • AI Confidence: 75%
click to see 🤖 AI reasoning details

The changes add an optional includeMarketData parameter to the useSearchRequest hook and set it to true in useTrendingSearch. This is a minor, additive change that enhances the trending tokens search functionality by including market data in the results.

Key observations:

  1. The changes are backward compatible - adding an optional parameter
  2. The feature affects the Trending Tokens view which displays token information and market data
  3. No E2E tests exist specifically for the trending feature
  4. The changes don't affect core wallet functionality, transactions, confirmations, or security-sensitive code
  5. The impact is limited to how trending/search token results are displayed with market data

The SmokeAssets tag is most appropriate as it covers "Asset management and display, NFTs, token details" which aligns with the trending tokens feature that displays token information including market data. The change is low risk because it's an additive enhancement to an existing feature without modifying critical paths.

View GitHub Actions results

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

@juanmigdr juanmigdr added this pull request to the merge queue Jan 9, 2026
Merged via the queue into main with commit ca15774 Jan 9, 2026
90 checks passed
@juanmigdr juanmigdr deleted the fix/missing-market-data-trending branch January 9, 2026 13:23
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2026
@metamaskbot metamaskbot added the release-7.62.0 Issue or pull request that will be included in release 7.62.0 label Jan 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.62.0 Issue or pull request that will be included in release 7.62.0 size-S team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants