chore: refactor testId selectors to avoid imports from app to e2e

[christopherferreira9]

Description

This PR aims to refactor test ID definitions to follow proper architectural guidelines by moving them from e2e/selectors/ into the application code. App code was importing test IDs from the e2e/ folder, creating an incorrect dependency where production code depends on test infrastructure. This moves test ID definitions to app/ code as *.testIds.ts files, co-located with their respective components. E2E page objects now import test IDs from app code instead of vice versa.

Changes

• Created *.testIds.ts files in app/ alongside their components
• Updated all app/ imports to use local testIds files
• Updated e2e/ page object imports to reference new app locations
• No logic changes - only file organization and import paths
• Existing selectors under e2e/ are test related files and are not imported in app/

Example

Before

// app/component-library/components/Cells/Cell/Cell.tsx
import { CellComponentSelectorsIDs } from '../../../../../e2e/selectors/wallet/CellComponent.selectors';

After

// app/component-library/components/Cells/Cell/Cell.tsx
import { CellComponentSelectorsIDs } from './CellComponent.testIds';

Notes

• Duplicate selector files remain in e2e/selectors/ for wdio compatibility (wdio deprecation planned)
• E2e-only selectors (test dapp, snaps, etc.) intentionally remain in e2e/selectors/

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Moves test selector definitions into app code and redirects imports away from e2e/.

• Adds co-located *.testIds.ts files across components (e.g., Cells, Toast, Network, Perps, Predict, Card, Wallet, Bridge, Browser, Modals) and points app/tests to them
• Replaces imports from e2e/selectors/* with local *.testIds paths; leaves e2e files for backward compatibility
• Minor adjustments: some constants typed as const, locale import path fixes, and a small text key update (delete_my → erase_my)

^{Written by Cursor Bugbot for commit 8221eed. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found

All E2E tests pre-selected.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
139 New issues
4 Accepted issues

Measures
25 Security Hotspots
92.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud