Skip to content

Conversation

@VGR-GIT
Copy link
Contributor

@VGR-GIT VGR-GIT commented Jan 8, 2026

Description

Allows users who've reached the appropriate tier to claim the metal card reward.

Changelog

CHANGELOG entry: allow metal card rewards claim when season 1 ends

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/RWDS-911


Note

Enables claiming the end-of-season Metal Card reward and improves end-of-season reward UX.

  • Add MetalCardClaimBottomSheet modal with email validation, optional Telegram handle, metrics, error banner, and success toast; register route REWARDS_METAL_CARD_CLAIM_BOTTOM_SHEET in navigators
  • Update PreviousSeasonUnlockedRewards to show Metal Card rewards as claimable and navigate to the new sheet; simplify messaging by removing store/version prompts
  • Enhance RewardItem with end-of-season logic: claim expiry (claimEndDate), time-left display, claimed/expired labels, disabled states, claim button variant/size tweaks, onPress override, and claim URL interpolation; block actions when locked/claimed/expired
  • Extend rewards types and utils: add SeasonRewardType.METAL_CARD, claimEndDate on season rewards, validateEmail, new i18n strings
  • Add/adjust tests for the new modal, previous season list, reward item behavior, and format utils

Written by Cursor Bugbot for commit 6cab01c. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-rewards Rewards team label Jan 8, 2026
@VGR-GIT VGR-GIT changed the title Rwds 911 metal card claim feat: rewards end of season metal card claim Jan 8, 2026
@VGR-GIT VGR-GIT force-pushed the rwds-911-metal-card-claim branch from a313257 to c44dd97 Compare January 8, 2026 12:21
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jan 8, 2026
@VGR-GIT VGR-GIT marked this pull request as ready for review January 8, 2026 12:40
@VGR-GIT VGR-GIT requested a review from a team as a code owner January 8, 2026 12:40
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 52.00000% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.52%. Comparing base (d672a66) to head (c44dd97).

Files with missing lines Patch % Lines
...ts/UI/Rewards/components/RewardItem/RewardItem.tsx 0.00% 44 Missing ⚠️
...s/PreviousSeason/PreviousSeasonUnlockedRewards.tsx 75.00% 2 Missing ⚠️
...CardClaimBottomSheet/MetalCardClaimBottomSheet.tsx 97.72% 0 Missing and 1 partial ⚠️
app/components/UI/Rewards/utils/formatUtils.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #24314       +/-   ##
===========================================
- Coverage   79.28%   51.52%   -27.77%     
===========================================
  Files        4065     4066        +1     
  Lines      107173   107247       +74     
  Branches    21830    21846       +16     
===========================================
- Hits        84971    55257    -29714     
- Misses      16248    47443    +31195     
+ Partials     5954     4547     -1407     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@VGR-GIT VGR-GIT force-pushed the rwds-911-metal-card-claim branch from 742a464 to 791b712 Compare January 8, 2026 15:06
@VGR-GIT VGR-GIT enabled auto-merge January 9, 2026 09:16
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeRewards
  • Risk Level: medium
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

This PR introduces a new Metal Card Claim feature within the Rewards system. The changes are well-scoped and focused:

  1. Critical File Analysis: The rewards-controller/types.ts file is marked as critical, but the changes are minimal type additions (adding claimEndDate property and METAL_CARD enum value). These are additive changes that don't modify existing behavior.

  2. Scope of Changes:

    • New MetalCardClaimBottomSheet component for claiming Metal Card rewards
    • Updates to RewardItem and PreviousSeasonUnlockedRewards components to handle the new reward type
    • New navigation route for the Metal Card claim flow
    • Email validation utility function
    • Localization strings for the new feature
  3. Risk Assessment:

    • All changes are contained within the Rewards feature domain
    • No changes to core wallet functionality, network handling, or other critical systems
    • The navigation changes only add a new screen without modifying existing routes
    • Comprehensive unit tests are included for all new functionality
    • The type changes are additive (new enum value, new optional property) and won't break existing code
  4. Test Tag Selection:

    • SmokeRewards is the appropriate tag as all changes relate to the Rewards feature
    • No other features are impacted by these changes
    • The MainNavigator.js change only adds a new screen to the Rewards navigation stack

The changes are medium risk because they touch a critical file (rewards-controller types) and add new navigation, but the impact is limited to the Rewards feature with no cross-cutting concerns.

View GitHub Actions results

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

@VGR-GIT VGR-GIT added this pull request to the merge queue Jan 9, 2026
Merged via the queue into main with commit ecf9c4a Jan 9, 2026
302 of 310 checks passed
@VGR-GIT VGR-GIT deleted the rwds-911-metal-card-claim branch January 9, 2026 15:29
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2026
@metamaskbot metamaskbot added the release-7.62.0 Issue or pull request that will be included in release 7.62.0 label Jan 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-7.62.0 Issue or pull request that will be included in release 7.62.0 size-XL team-rewards Rewards team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants