Skip to content

Conversation

@salimtb
Copy link
Contributor

@salimtb salimtb commented Jan 8, 2026

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​@​metamask/​assets-controllers@​95.0.0981009197100

View full report

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeCore, SmokeConfirmationsRedesigned, SmokeWalletPlatform, SmokeWalletUX, SmokeAssets, SmokeSwaps, SmokeStake, SmokeRamps, SmokeTrade, SmokeNetworkExpansion, SmokeMultiChainPermissions
  • Risk Level: high
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

This PR contains two significant changes:

  1. AccountTrackerController Messenger Changes: Added KeyringController:getState action and KeyringController:lock event to the AccountTrackerController messenger. This is a critical change in the Engine's core messaging infrastructure that allows the AccountTrackerController to respond to wallet lock events and query keyring state. This affects how account balances are tracked and could impact security-related behavior when the wallet is locked.

  2. Major Dependency Upgrade: @metamask/assets-controllers upgraded from v94.1.0 to v95.0.0 (major version bump). This package is fundamental to the wallet's asset management and includes controllers for:

    • AccountTrackerController (account balances)
    • TokensController, TokenBalancesController, TokenRatesController
    • NftController, NftDetectionController
    • And other asset-related controllers

The AccountTrackerController is used extensively across the codebase:

  • Confirmations (native balance display, token balances)
  • Staking features (balance hooks)
  • Ramps/Buy-Sell (balance checks)
  • Bridge functionality (token balances)
  • Gas polling
  • Network switching
  • Asset display throughout the wallet

Given the critical nature of these changes (core Engine infrastructure + major dependency upgrade affecting asset management), comprehensive testing is warranted to ensure:

  • Account balances display correctly
  • Wallet lock/unlock behavior works properly
  • All asset-related features function correctly
  • Confirmations show correct balances
  • Staking, swaps, bridge, and ramps work with balance data

View GitHub Actions results

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants