Skip to content

Conversation

@racitores
Copy link
Contributor

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Jan 8, 2026
@racitores racitores added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed team-qa QA team and removed team-qa QA team labels Jan 8, 2026
@github-actions github-actions bot added the size-L label Jan 8, 2026
@racitores racitores changed the title ASSETS-1514: add e2e trending test: ASSETS-1514 - add e2e trending Jan 8, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform, SmokeWalletUX
  • Risk Level: medium
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

The changes consist of:

  1. E2E Framework Infrastructure Changes (Critical paths):

    • e2e/framework/types.ts: Added optional priority field to MockApiEndpoint interface - this is a backward-compatible addition
    • e2e/api-mocking/helpers/mockHelpers.ts: Added new setupMockEvents function - this is additive and doesn't modify existing functions
    • e2e/api-mocking/helpers/mockHelpersExtended.ts: New file with similar functionality
  2. New Trending Feature Tests:

    • Three new test specs for a "Trending" feature
    • trending-browser.spec.ts uses SmokeWalletPlatform tag
    • trending-feed-smoke.spec.ts uses SmokeWalletUX tag
    • trending-search.spec.ts uses SmokeWalletPlatform tag
    • New page object TrendingView.ts and mock responses trending-api-mocks.ts

The framework changes are additive and don't modify existing behavior - they add a new optional field and a new utility function. The existing MockEventsObject interface and mock helpers remain unchanged in their core functionality.

Since these are new tests being added, we should run the tags they use to verify the new tests work correctly. The infrastructure changes are low-risk as they're purely additive.

View GitHub Actions results

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-L team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants