-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: remove balance section for non evm when zero #24332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: remove balance section for non evm when zero #24332
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| } | ||
| } | ||
| > | ||
| <Text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trying to remove all snapshots in this file was time consuming;
another approach i tried was updating the mock to 100 which updates the snapshot to keeo this balance section with balance 100 instead of zero
There were couple issues with these snapshots;
Snapshots captured the loading state (just an ActivityIndicator), so they never tested the fully-rendered component.
When we tried explicit assertions, the component actually rendered fully, which exposed:
Async timing - assertions ran before loading finished
Wrong mock addresses - EVM transactions couldn't match Solana account address
Missing mock data - transactions missing id field
....
Each fix exposed the next issue deeper in the component tree.
Thinking it should be treated as tech debt outside of this PR
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsThe change modifies how balance is displayed in the AssetOverview component for multichain assets. Specifically, when The change is:
This is a UI display fix that improves user experience by not showing incorrect "0" balances when the actual balance is unknown or loading. The risk is medium because:
Selected tags:
|
|




Description
PR to remove balance section in asset details page when non evm token balance is zero.
Changelog
CHANGELOG entry: Removes Non evm balance section in asset details page when zero
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2026-01-08.at.18.51.17.mov
After
Screen.Recording.2026-01-08.at.18.50.33.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Hides zero balances for non‑EVM assets on the asset details screen.
AssetOverview.tsx, whenisMultichainAssetand nobalanceSource, setbalancetoundefined(was0), and renderBalanceonly whenbalance != nullWritten by Cursor Bugbot for commit 26f617d. This will update automatically on new commits. Configure here.