Skip to content

Conversation

@mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Jan 8, 2026

Description

In the reveal SRP flow, the user cannot scroll the accounts list inside the component with the SRP once this one is expanded

Changelog

CHANGELOG entry: bug fix where a user couldn't scroll through the SRP reveal bottom sheet on Android

Related issues

Fixes: #19999
Jira ticket: https://consensyssoftware.atlassian.net/browse/MUL-1366

Manual testing steps

Feature: reveal SRP screen

  Scenario: user wants to see all of one SRP's accounts on Android
    Given user has multiple SRPs with more than 10 EVM accounts in each

    When user goes to settings > security > reveal SRP > XX accounts
    Then user is able to scroll down the list of accounts without issues

Screenshots/Recordings

Before

Screen.Recording.2025-09-18.at.20.48.34.mov

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Resolves Android scrolling issues in the SRP reveal bottom sheet by constraining list height and enabling nested scrolling.

  • Updates SRPList to use useWindowDimensions and pass vars.maxHeight (~70% of window height) to styleSheet
  • Adds maxHeight to SRPList.styles.ts and a flatList style (flexGrow: 0) to prevent over-expansion
  • Switches FlatList to react-native-gesture-handler and enables scrollEnabled/nestedScrollEnabled
  • Cleans up redundant flex styles in base and srpListContentContainer

Written by Cursor Bugbot for commit a5650b9. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-accounts-framework Accounts Framework team label Jan 8, 2026
@mathieuartu mathieuartu self-assigned this Jan 8, 2026
@github-actions github-actions bot added the size-S label Jan 8, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeWalletPlatform
  • Risk Level: medium
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

The changes modify the SRPList component which is used in multiple account management flows:

  1. Style changes: Modified the base container styling (removed flex properties, added maxHeight) and added a new flatList style with flexGrow: 0
  2. Component changes: Switched from React Native's FlatList to react-native-gesture-handler's FlatList, and added dynamic maxHeight calculation based on window dimensions (70% of screen height)

These changes affect:

  • SelectSRP view (used when revealing recovery phrase)
  • AddNewAccount view (used when adding accounts to specific SRPs)
  • WalletRecovery view
  • ProtectYourWallet settings section

The E2E tests in the multisrp folder (add-account.spec.ts, export-srp-from-settings.spec.ts) and accounts folder (reveal-secret-recovery-phrase.spec.ts, import-srp.spec.ts) directly test these flows and use the SRPList component.

Selected tags:

  • SmokeAccounts: Covers account management, keyrings, and SRP reveal functionality
  • SmokeWalletPlatform: Covers multi-SRP functionality including adding accounts to specific SRPs and exporting SRPs

Risk is medium because:

  • The changes are primarily UI/styling related
  • The switch to react-native-gesture-handler's FlatList could affect scrolling behavior in bottom sheets
  • The maxHeight constraint could affect how the list displays with many SRPs

View GitHub Actions results

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you add a recording on the fix on the PR description?

@gantunesr gantunesr added this pull request to the merge queue Jan 9, 2026
Merged via the queue into main with commit 1e5e26c Jan 9, 2026
171 of 173 checks passed
@gantunesr gantunesr deleted the fix/android-scroll-srp-accounts-security branch January 9, 2026 19:18
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2026
@metamaskbot metamaskbot added the release-7.62.0 Issue or pull request that will be included in release 7.62.0 label Jan 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.62.0 Issue or pull request that will be included in release 7.62.0 size-S team-accounts-framework Accounts Framework team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: cannot scroll to see full account list on settings reveal srp page

4 participants