-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: android scroll issue on reveal srp bottom sheet #24338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsThe changes modify the SRPList component which is used in multiple account management flows:
These changes affect:
The E2E tests in the multisrp folder (add-account.spec.ts, export-srp-from-settings.spec.ts) and accounts folder (reveal-secret-recovery-phrase.spec.ts, import-srp.spec.ts) directly test these flows and use the SRPList component. Selected tags:
Risk is medium because:
|
|
gantunesr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, can you add a recording on the fix on the PR description?



Description
In the reveal SRP flow, the user cannot scroll the accounts list inside the component with the SRP once this one is expanded
Changelog
CHANGELOG entry: bug fix where a user couldn't scroll through the SRP reveal bottom sheet on Android
Related issues
Fixes: #19999
Jira ticket: https://consensyssoftware.atlassian.net/browse/MUL-1366
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2025-09-18.at.20.48.34.mov
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Resolves Android scrolling issues in the SRP reveal bottom sheet by constraining list height and enabling nested scrolling.
SRPListto useuseWindowDimensionsand passvars.maxHeight(~70% of window height) tostyleSheetmaxHeighttoSRPList.styles.tsand aflatListstyle (flexGrow: 0) to prevent over-expansionFlatListtoreact-native-gesture-handlerand enablesscrollEnabled/nestedScrollEnabledbaseandsrpListContentContainerWritten by Cursor Bugbot for commit a5650b9. This will update automatically on new commits. Configure here.