Skip to content

Conversation

@Matt561
Copy link
Contributor

@Matt561 Matt561 commented Jan 9, 2026

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeTrade, SmokeAssets, SmokeStake
  • Risk Level: medium
  • AI Confidence: 72%
click to see 🤖 AI reasoning details

This PR contains significant changes to the mUSD (MetaMask USD) conversion feature within the Earn module:

  1. Earn/Staking Changes: Major refactoring of mUSD-related hooks (useMusdCtaVisibility, useMusdBalance, useMusdConversionTokens, useEarnToasts, useMusdConversionStatus), new feature flag selectors, and UI updates to the EarnMusdConversionEducationView. The stake E2E test uses SmokeTrade tag.

  2. Token List Changes: TokenListItem.tsx now uses the new useMusdCtaVisibility hook to determine when to show mUSD conversion CTAs. This affects how tokens are displayed in the wallet.

  3. Confirmations Changes: New EarningPercentageRow component added to custom-amount-info.tsx for mUSD conversion transactions. This affects the confirmation flow UI.

  4. Asset Overview Changes: EarnLendingBalance component updated to use new visibility hooks for mUSD conversion CTAs.

The changes are primarily feature-flag gated (multiple new flags added), which reduces risk. However, the refactoring touches multiple interconnected components in the Earn module and affects token display and confirmation flows.

Selected tags:

  • SmokeTrade: The stake test uses this tag, and the Earn module changes could affect staking/trading flows
  • SmokeAssets: TokenListItem changes affect asset display in the wallet
  • SmokeStake: Direct changes to staking/earn functionality

The version bump and bitrise.yml changes are routine and don't require additional testing beyond what's covered by the functional changes.

View GitHub Actions results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants