chore(runway): cherry-pick fix(tron): max energy and bandwidth incorrectly set to 1 instead of 0 cp-7.61.6#24376
Conversation
…ectly set to 1 instead of 0 cp-7.61.6 (#24368) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Fix Tron resources calculation and default value. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Fixes Tron resource max handling and safe percentage calculation. > > - `useTronResources`: passes actual `max` values (can be `0`) to `createResource`; percentage uses `Math.max(1, max)` to avoid divide-by-zero while preserving displayed `max` > - Tests updated to expect `max: 0` when no resources exist; existing parsing and capping behaviors verified > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit d0c7e87. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsThis PR introduces a new custom hook Analysis:
Test tag selection rationale:
Why not other tags:
Confidence: 85% - Clear understanding of the changes and their scope. The hook is well-tested with unit tests, has limited scope, and uses existing infrastructure. Slightly lower than 100% only because this is a new feature that should be verified in the context of the full asset overview flow for Tron. |
|
No release label on PR. Adding release label release-7.61.6 on PR, as PR was cherry-picked in branch 7.61.6. |
Description
Fix Tron resources calculation and default value.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Fix Tron resources calculation and defaults
useTronResources, keep actualmaxvalues from data (can be0) and computepercentageusingMath.max(1, max)to avoid division by zeromaxto at least1for energy/bandwidthuseTronResources.test.tsto expectmax: 0when resources are absent and validate parsing/percentage behaviorWritten by Cursor Bugbot for commit df247ca. This will update automatically on new commits. Configure here.
Co-authored-by: Antonio Regadas antonio.regadas@consensys.net ae67bf2