chore: Proposal 1 yaml base config inheritance #24563
Draft
+954
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
tommasini
changed the title
Contributor
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsAll changes in this PR are related to CI/CD infrastructure and build configuration management:
None of these changes affect:
These are purely CI/CD and build infrastructure changes that don't require E2E testing validation. The changes are well-isolated to the build/deployment pipeline and don't touch any code paths that would be exercised by E2E tests. |
- Add base.yml with shared configuration (servers, features, common secrets) - Add environment-specific configs (prod, rc, exp) that extend base - Add merge-config.js script to merge base + environment configs - Add set-secrets-from-config.js helper for secret mapping - Add build.yml workflow that uses merged configurations - Add js-yaml dependency for YAML parsing - Add README explaining the configuration structure This proposal uses a base configuration file with inheritance pattern, allowing shared values to be defined once and environment-specific overrides to be minimal and clear. Co-authored-by: tomas.santos <[email protected]>
cursor
bot
force-pushed
the
proposal-1-yaml-base-config-inheritance
branch
from
daa9ce1 to
1f63bc8
Compare
This MVP provides the minimal structure needed to start migrating to the new YAML-based configuration system. Changes: - Keep base.yml with shared configuration - Add prod.yml and rc.yml as example environments - Simplify merge-config.js script - Remove exp.yml (will be added during migration) - Remove set-secrets script (not needed for MVP) - Remove workflow file (will be added during migration) - Update README to explain MVP scope This MVP allows teams to: 1. Test the merge script locally 2. Start migrating configs incrementally 3. Extend with more environments/build types later Next steps during migration: - Add remaining environments (exp, beta, test, dev, e2e) - Add build-types separation (main vs flask) - Add combinations directory - Integrate with GitHub Actions workflows - Add code fencing configuration Co-authored-by: tomas.santos <[email protected]>
Implements the complete hierarchical configuration system: Structure: - base.yml: Universal defaults shared by all builds - build-types/: Common config for main and flask builds (code fencing, OAuth) - environments/: Common config for each environment (prod, beta, rc, test, exp, dev, e2e) - combinations/: Specific overrides for build-type + environment combinations Features: - Hierarchical inheritance: base → build-type → environment → combination - Code fencing centralized in build-type configs - All 12 combinations supported (main-prod, main-rc, flask-prod, etc.) - Enhanced merge-config.js with code fencing resolution - Updated metro.transform.js to use config (with fallback) - GitHub Actions workflow integration - Secret management helper script Benefits: - DRY: Shared configs defined once - Maintainable: Update base to change all environments - Scalable: Easy to add new environments/build types - Single source of truth for all combinations - Removes remapping logic from build.sh - Centralizes code fencing configuration Co-authored-by: tomas.santos <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist